Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Block experiments classname package #6861

Merged
merged 6 commits into from
May 14, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented May 13, 2024

Related PR:

This PR adds a new step to install dependencies of the block-experiments submodule. Currently, we were relying on Gutenberg to have all needed dependencies for this submodule, but since the recent removal of the classnames package, it makes sense this submodule also installs its dependencies as we do it for Jetpack and Gutenberg.

It adds a new bash file to install the block-experiments dependencies, which will be called in the postinstall script in Gutenberg Mobile's package.json

A new item was added to Metro's block list, to not include files from the @wordpress package from its dependencies, the reason for this is to solve problems with bringing old references of older versions of the native files. This shouldn't affect anything as we are loading these packages from Gutenberg already.

To test CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added this to the 1.119.0 (24.9) milestone May 14, 2024
@geriux geriux added the dependencies Pull requests that update a dependency file label May 14, 2024
@geriux geriux requested a review from twstokes May 14, 2024 10:03
@geriux geriux marked this pull request as ready for review May 14, 2024 10:03
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for this item to be resolved before reviewing. Feel free to re-request after it's been resolved. Thanks!

@geriux
Copy link
Contributor Author

geriux commented May 14, 2024

Will wait for this item to be resolved before reviewing. Feel free to re-request after it's been resolved. Thanks!

Done! I decided to not unify both just in case separate configurations are preferred for each submodule 👍

@geriux geriux requested a review from twstokes May 14, 2024 15:06
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @geriux. 🚀

@twstokes twstokes merged commit 6b64d20 into trunk May 14, 2024
23 checks passed
@twstokes twstokes deleted the fix/block-experiments-packages branch May 14, 2024 21:28
@geriux
Copy link
Contributor Author

geriux commented May 16, 2024

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

@twstokes
Copy link
Contributor

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

Ah! My bad on that. 😬

@twstokes twstokes mentioned this pull request May 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants