Release 1.112.0 #6597

derekblank · 2024-02-01T06:14:12Z

Release for Gutenberg Mobile 1.112.0

Related PRs

Changes

Change 1: Fix crash occurring on large post on Android
Change 2: Upgrade React Native to version 0.71.15
Change 3: Prevent images from temporarily disappearing when uploading media

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

Verify Items from test plan have been completed
Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
Bundle package of the release is updated.

fluiddot · 2024-02-01T11:56:50Z

Release Submission Checklist
Verify Items from test plan have been completed

@derekblank we usually perform the testing plan the week after the release. Not sure if you already covered this, although I don't see comments in this PR related to testing. Let me know if we should leave it unchecked. Thanks 🙇 !

fluiddot · 2024-02-01T12:11:11Z

In 5d9a47f, I noticed that some E2E tests failed:

Test iOS on Device – Full iPhone

Gutenberg Editor Visual test for Gallery Block › should be able to render a gallery correctly
- There are visual differences

Test iOS on Device – Full iPad

Gutenberg Editor iPad Visual test for Horizontal layouts should show the right columns placeholders and alignments case 1
- The scroll positions don't match by some pixels.

Gutenberg Editor iPad Visual test for Horizontal layouts should show the right columns placeholders and alignments case 2
- The device didn't rotate.

I'm going to retry the tests but if they fail again, it would be great to investigate them further.

fluiddot · 2024-02-01T17:42:48Z

I'm going to retry the tests but if they fail again, it would be great to investigate them further.

They keep failing, so I'm going to take a deeper look.

fluiddot · 2024-02-01T18:29:57Z

Test iOS on Device – Full iPhone

Gutenberg Editor Visual test for Gallery Block › should be able to render a gallery correctly

There are visual differences

It's a bit subtle but I noticed that the images seem one pixel taller, this seems causing the first failure. I wonder if #6550 has impacted somehow the size.

UPDATE: I confirmed that #6550 added 1 pixel.

Left (old) | Right (new):

fluiddot · 2024-02-01T18:43:04Z

It's a bit subtle but I noticed that the images seem one pixel taller, this seems causing the first failure. I wonder if #6550 has impacted somehow the size.

UPDATE: I confirmed that #6550 added 1 pixel.

I presume that the extra pixel was unintended. However, since it doesn't produce a critical change to the editor, I'll proceed with updating the screenshots. @derekblank let me know if you'd rather remove the extra pixel. If so, we could update the screenshots again. Thanks 🙇 !

This is needed to reflect a minor change in the size of the image frame.

fluiddot · 2024-02-01T19:00:30Z

Test iOS on Device – Full iPad

Gutenberg Editor iPad Visual test for Horizontal layouts should show the right columns placeholders and alignments case 1

The scroll positions don't match by some pixels.

Gutenberg Editor iPad Visual test for Horizontal layouts should show the right columns placeholders and alignments case 2

The device didn't rotate.

This case is the same as the one shared in #6597 (comment). The one-pixel size difference in the image frame makes the visual check to fail. I'll proceed to update the screenshots.

fluiddot

LGTM 🎊 !

Pre-approving the PR upon waiting E2E tests to pass after the following fixes:

derekblank · 2024-02-02T06:57:05Z

I presume that the extra pixel was unintended. However, since it doesn't produce a critical change to the editor, I'll proceed with updating the screenshots. @derekblank let me know if you'd rather remove the extra pixel.

@fluiddot The extra pixel is actually intended, but I didn't realize that the E2E screenshots would be that sensitive to detect such a small visual change. It makes sense, however, so thanks for updating the screenshots. We can keep them as-is.

To provide more technical detail on the 1 pixel change, the extra pixel comes from a non-visible FastImage instance that acts as a preloader using its onLoad method to download the network image data and smoothly transition between the local and network image states when the network image data is ready. This non-visible image is a workaround due to the FastImage preload method not returning a Promise or callback to hook into. There is more discussion and explanation on this change in the iOS section of the internal ref p2-p9ugOq-4lR. It's worth noting that the onLoad behavior from this non-visible image does not fire if the image does not have a width/height of at least 1. We did try using 0 as the dimension value, and the onLoad method did not work as intended (ref).

Also noting that @dcalhoun and I consider this change a progressive-enhancement interim fix while we explore longer-term solutions for the Image component as a group, and potentially moving away from FastImage due to lack of maintenance.

derekblank · 2024-02-06T02:55:44Z

derekblank · 2024-02-06T02:56:36Z

🟢 Unsupported Block Editor - Android

Build: jpandroid-24.2-rc-1
Device: Samsung Galaxy S20 FE 5G

TC001 - User can edit unsupported blocks on Simple WP.com sites
TC002 - User can discard edits to an unsupported block on Simple WP.com sites
TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

derekblank · 2024-02-06T03:01:50Z

derekblank · 2024-02-06T05:15:59Z

derekblank · 2024-02-06T05:20:15Z

🟢 Unsupported Block Editor - iOS

Build: pr22539-1bfe5e4
Device: iPhone SE

TC001 - User can edit unsupported blocks on Simple WP.com sites
TC002 - User can discard edits to an unsupported block on Simple WP.com sites
TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

derekblank · 2024-02-06T05:22:35Z

derekblank added 4 commits February 1, 2024 16:02

Release script: Update gutenberg submodule

952885d

1.112.0

c63394a

Release script: Sync XCFramework Podfile.lock with 1.112.0

257f85e

Release script: Update release notes for version 1.112.0

5d9a47f

derekblank added the release-process label Feb 1, 2024

This was referenced Feb 1, 2024

Integrate gutenberg-mobile release v1.112.0 wordpress-mobile/WordPress-Android#20093

Merged

Integrate gutenberg-mobile release v1.112.0 wordpress-mobile/WordPress-iOS#22513

Merged

derekblank requested review from fluiddot and geriux February 1, 2024 07:54

derekblank mentioned this pull request Feb 1, 2024

Mobile Release v1.112.0 WordPress/gutenberg#58540

Merged

Update Gutenberg ref

d32e68d

fluiddot added 2 commits February 1, 2024 19:46

Update screenshot of Gallery Block E2E

a4ea932

This is needed to reflect a minor change in the size of the image frame.

Update screenshot of iPad horizontal layouts E2E

4a0a8a4

This is needed to reflect a minor change in the size of the image frame.

fluiddot mentioned this pull request Feb 1, 2024

Update Image component to avoid flicker when updating the URI #6550

Merged

fluiddot approved these changes Feb 1, 2024

View reviewed changes

Update Gutenberg ref to 1.112.0 merge commit

23d443f

derekblank merged commit 51f84e6 into trunk Feb 2, 2024
23 checks passed

derekblank deleted the release/1.112.0 branch February 2, 2024 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.112.0 #6597

Release 1.112.0 #6597

derekblank commented Feb 1, 2024 •

edited

Loading

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024 •

edited

Loading

Test iOS on Device – Full iPhone

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024

Test iOS on Device – Full iPad

fluiddot left a comment

derekblank commented Feb 2, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024

derekblank commented Feb 6, 2024

derekblank commented Feb 6, 2024 •

edited

Loading

Release 1.112.0 #6597

Release 1.112.0 #6597

Conversation

derekblank commented Feb 1, 2024 • edited Loading

Related PRs

Changes

Test plan

Release Submission Checklist

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024

Test iOS on Device – Full iPhone

Test iOS on Device – Full iPad

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024 • edited Loading

Test iOS on Device – Full iPhone

fluiddot commented Feb 1, 2024

fluiddot commented Feb 1, 2024

Test iOS on Device – Full iPad

fluiddot left a comment

Choose a reason for hiding this comment

derekblank commented Feb 2, 2024 • edited Loading

derekblank commented Feb 6, 2024 • edited Loading

🟢 Writing Flow checklist - Android

General

Rich Text Format

Splitting and merging

derekblank commented Feb 6, 2024 • edited Loading

🟢 Unsupported Block Editor - Android

derekblank commented Feb 6, 2024 • edited Loading

🟢 Functionality Test Suite 2 - Android

DarkMode - 1

Group - 1

Buttons-1

Button-2

Button-3

Color Settings - 1

Image - 1

Drag and Drop Blocks - 1

VideoPress - 2

derekblank commented Feb 6, 2024

🟢 Writing Flow checklist - iOS

General

Rich Text Format

Splitting and merging

derekblank commented Feb 6, 2024

🟢 Unsupported Block Editor - iOS

derekblank commented Feb 6, 2024 • edited Loading

🟡 Functionality Test Suite 3 - iOS

Gallery - 2

Gallery - 3

MediaText - 3

MediaText - 4

Shortcode-1

Cover - 2

Image - 2

Story block - 1

derekblank commented Feb 1, 2024 •

edited

Loading

fluiddot commented Feb 1, 2024 •

edited

Loading

derekblank commented Feb 2, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading

derekblank commented Feb 6, 2024 •

edited

Loading