Fix yarn makepot #658
Closed
Fix yarn makepot #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es the xgettext command line
koke
reviewed
Feb 25, 2019
package.json
Outdated
| @@ -59,7 +59,8 @@ | |||
| "bundle:ios": "mkdir -p bundle/ios && yarn react-native bundle --platform ios --dev false --entry-file index.js --assets-dest bundle/ios --bundle-output bundle/ios/App.js --sourcemap-output bundle/ios/App.js.map", | |||
| "i18n-cache": "node i18n-cache/index.js", | |||
| "postinstall": "yarn i18n-cache", | |||
| "makepot": "xgettext -f <( find . \\( -path './gutenberg/*/src/*.native.js' -or -path './src/*.js' \\) ! -path 'node_modules' -print ) --from-code=UTF-8 -k__ -k_n -k_x -k_nx -x ./gutenberg/languages/gutenberg.pot -o ./gutenberg-mobile.pot", | |||
| "premakepot": "npm run build --prefix gutenberg", | |||
There was a problem hiding this comment.
Wouldn't this still need a npm install inside gutenberg, leaving a populated node_modules there?
|
This is out of date since babel-plugin-makepot was removed from gutenberg in WordPress/gutenberg#12559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a priority for 1.0 release but it could use a fix. Not touching anything critical...
Just fixing the the pot file generation using the xgettext command line.
The current command assumes
gutenberg.potis generated ingutenberg/languages/and that bash is the default shell to run commands (sh is probably the default one actually)