Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPAndroid Integration Doc with Details about Dependant Tests #3396

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Apr 20, 2021

This PR includes a small update to the WPAndroid Integration doc. Specifically, it includes a note about waiting for tests to pass in gutenberg-mobile before CI tests will pass in WPAndroid.

This follows some internal confusion that can be found in the following threads:

  • p1618930814021100-slack-CC7L49W13
  • p1618582902446600/1618581573.439100-slack-C0126N6JH7Z
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Updates the WPAndroid Integration doc to include a note about waiting for tests to pass in gutenberg-mobile.
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thank you for putting this together. I think this will help others in the future.

WPAndroid Integration.md Outdated Show resolved Hide resolved
Co-authored-by: David Calhoun <dpcalhoun@gmail.com>
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 20, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@SiobhyB SiobhyB merged commit 4143d27 into develop Apr 20, 2021
@SiobhyB SiobhyB deleted the update/wpandroid-integration-documentation branch April 20, 2021 19:19
@SiobhyB SiobhyB changed the title Update WPAndroid Integration with Details about Dependant Tests Update WPAndroid Integration Doc with Details about Dependant Tests Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants