Send selection change event when typing #1867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865
Experimental fix by dispatching a
ReactAztecSelectionChangeEvent
when text is changed in (Android) Aztec's manager.This fix needs some extensive testing since the extra selection changed event could have side effects in other features.
Thing is, selection changed events should be sent out anyway by this code but it looks like the listener is suspended because of this code on the Aztec side.
@khaykov , I know it's been a while now since that code was written but, do you remember who/when should re-enable the selection change listener after the
ZeroIndexContentWatcher
has disabled it?Edit: latest fix on this PR is on the Aztec side. PR here: wordpress-mobile/AztecEditor-Android#892
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.