Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DependencyGraph.js so the original file is not left over after yarn bundle #1732

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

mchowning
Copy link
Contributor

This PR insures that DependencyGraph.js is not left in the root directory after running yarn bundle

Description

Running yarn bundle patches metro to not watch files while bundling (original PR). It does this by copying a patched DependencyGraph.js file into the node_modules folder before bundling that disables watching. Then after bundling is finished it copies the original DependencyGraph.js file back into node_modules, but it (currently) leaves that file at the root of the directory.

This PR uses mv instead of cp when restoring that DependencyGraph.js back to the node_modules folder. As a result, after running yarn bundle there is no longer a leftover DependencyGraph.js file in the root directory.

To Test

  1. Run yarn clean:install
  2. grab a cup of coffee
  3. Run yarn bundle
  4. Finish the cup of coffee and grab a fresh cup
  5. Verify that both:
    1. yarn bundle completed successfully; and
    2. There is no DependencyGraph.js file in the root folder after the command completes

Once this PR is merged we can remove the references to deleting DependencyGraph.js from our Release Checklist.

PR submission checklist

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this 👍

@mchowning mchowning merged commit 9ba1ee9 into develop Jan 7, 2020
@mchowning mchowning deleted the yarn_version_cleanup branch January 7, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants