Import new location for base styles #1435
Conversation
| @@ -67,6 +67,7 @@ if ( reactNativeMinorVersion >= 59 ) { | |||
| const autoImportIncludePaths = [ | |||
| path.join( path.dirname( __filename ), 'src' ), | |||
| path.join( path.dirname( __filename ), 'gutenberg/assets/stylesheets' ), | |||
There was a problem hiding this comment.
This line can be removed.
| path.join( path.dirname( __filename ), 'gutenberg/assets/stylesheets' ), |
There was a problem hiding this comment.
It can, after WordPress/gutenberg#17883 is merged 😉
I left that so we don't have to coordinate merging both PRs. Once the base-styles are merged, we can remove that line in another PR.
There was a problem hiding this comment.
I think it's a good strategy in this case to keep both the "old" and the new paths so we smoothly transition to the new one. I'm approving this PR, but let us know if you have some more feedback here @gziolo and we can address it in the follow up PR.
There was a problem hiding this comment.
LGTM!
Tested both with and without WordPress/gutenberg#17883 in place.
And good to see this fix land before the web-side change lands, thanks Koke!
In WordPress/gutenberg#17883 the base SCSS styles are moving to a separate package. This updates our SASS transformer so it knows to look for them in the new path.
This can be merged before WordPress/gutenberg#17883 since I didn't remove the old location.
To test:
Update the gutenberg submodule to WordPress/gutenberg#17883 and see if everything runs correctly
Update release notes:
RELEASE-NOTES.txt.