Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for video block crash on drawing on Android #1046

Merged
merged 4 commits into from
May 29, 2019

Conversation

daniloercoli
Copy link
Contributor

This PR is a quick fix for wordpress-mobile/WordPress-Android#9943
Makes sure to not set background color on Android.

To test:
See details WordPress/gutenberg#15857

Update release notes:

[ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@daniloercoli daniloercoli added [Type] Bug Something isn't working [OS] Android labels May 29, 2019
@daniloercoli daniloercoli added this to the v1.7 milestone May 29, 2019
@daniloercoli daniloercoli requested a review from mkevins May 29, 2019 09:42
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on Android (via WordPress-Android), and it does prevent the crash as described. LGTM! 🎉

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants