Focus blocks on Android Device Tests #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include variable for debugging tests in command
Generated by 🚫 dangerJS |
JavonDavis
commented
May 28, 2019
| @@ -84,7 +84,7 @@ | |||
| "test:inside-gb": "cross-env NODE_ENV=test jest --verbose --config jest_gb.config.js", | |||
| "test:debug": "cross-env NODE_ENV=test node --inspect-brk jest --runInBand --verbose --config jest.config.js", | |||
| "device-tests": "cross-env NODE_ENV=test jest --runInBand --reporters=default --reporters=jest-junit --detectOpenHandles --verbose --config jest_ui.config.js", | |||
| "device-tests:debug": "cross-env NODE_ENV=test node --inspect-brk node_modules/jest/bin/jest --runInBand --reporters=default --reporters=jest-junit --detectOpenHandles --verbose --config jest_ui.config.js", | |||
| "device-tests:debug": "cross-env NODE_ENV=test node $NODE_DEBUG_OPTION --inspect-brk node_modules/jest/bin/jest --runInBand --reporters=default --reporters=jest-junit --detectOpenHandles --verbose --config jest_ui.config.js", | |||
There was a problem hiding this comment.
Needed for debugging in IntelliJ
Tug
approved these changes
May 28, 2019
There was a problem hiding this comment.
LGTM 👍
New paragraph should autofocus in theory, so it's more of a problem with how we handle the focus/selected state.
As far as I understand (and @hypest could confirm maybe) this is a tricky problem that we have not completely solved yet on mobile. So I can understand if this is needed as a "temporary fix".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to focus on blocks before sending text to them on Android. In some cases, if this wasn't done the text would be sent to the wrong block.
To test:
Update release notes:
RELEASE-NOTES.txt.