Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Issues on list block #1461

Open
koke opened this issue Oct 18, 2019 · 1 comment
Open

RTL Issues on list block #1461

koke opened this issue Oct 18, 2019 · 1 comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile Blocks RTL [Type] Bug Something isn't working

Comments

@koke
Copy link
Member

koke commented Oct 18, 2019

I noticed a bunch of issues when I set my simulator to Hebrew:

  • No space between bullet and cursor when inserting a list block
  • Number in numbered lists should show period before number
  • Undo/redo buttons should be flipped
  • Indent/outdent buttons should be flipped

Simulator Screen Shot - iPhone 11 - 2019-10-18 at 11 27 21
Simulator Screen Shot - iPhone 11 - 2019-10-18 at 11 29 16

@hypest worth considering for V2, I haven't tested other blocks

Note that the toolbar buttons also seem to have the same issues on the web (tested in https://he.wordpress.org/gutenberg/), as they rely heavily on some magic css to automatically flip things around except cases like this where it depends on the meaning of the button. As we fix this, we should consider what's a good cross-platform way to specify changes to the default layout direction (cc @pinarol)

@koke koke added [Type] Bug Something isn't working Blocks Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile labels Oct 18, 2019
@koke
Copy link
Member Author

koke commented Oct 18, 2019

Related: WordPress/gutenberg#8674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile Blocks RTL [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants