Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Block: Increase/Decrease Indent icons should be switched when using RTL language. #8674

Closed
kjellr opened this issue Aug 7, 2018 · 2 comments
Labels
[Block] List Affects the List Block [Feature] Blocks Overall functionality of blocks Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 7, 2018

Describe the bug

When using a LTR language, the arrows on the increase/decrease indent buttons on the List block indicate the direction the text will move when you press the button:

list-ltr

When you switch to a RTL language, the arrows do not point in the direction that the text will move:

list-rtl

I'd argue that these icons should be swapped when a RTL language is being used, so that the arrows properly represent the direction text will be moving.

To Reproduce

  1. Switch to a RTL language (Arabic, Hebrew, etc)
  2. Insert a list block with at least two items.
  3. Toggle the indent, using the toolbar buttons.

Tested in

Mac OS 10.13.6, Safari 11.1.2
Mac OS 10.13.6, Chrome 67.0.3396.99

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Aug 7, 2018
@sarahmonster sarahmonster mentioned this issue Aug 7, 2018
13 tasks
@designsimply designsimply added the [Block] List Affects the List Block label Oct 16, 2018
@ellatrix ellatrix added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Feb 11, 2019
@draganescu
Copy link
Contributor

As an example of prior art, Google Docs has slightly different icons:

  • English

en

  • Arabic

ar

@Mamaduka
Copy link
Member

This should be fixed after recent refactoring #39773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Feature] Blocks Overall functionality of blocks Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants