-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Global Styles] Implement Global Styles endpoint #394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsnyder
added
enhancement
New feature or request
[Status] DO NOT MERGE
[Status] In Progress
labels
Apr 29, 2021
11 tasks
chipsnyder
force-pushed
the
gutenberg/issue/3163-gss
branch
from
May 6, 2021 17:43
d35233c
to
6289cf3
Compare
This was referenced May 6, 2021
Merged
antonis
approved these changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Chip 👍
Tested this via the iOS PR and works as expected. The code also looks great 🎉
chipsnyder
force-pushed
the
gutenberg/issue/3163-gss
branch
from
June 16, 2021 18:57
e91386b
to
cb854d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#3163
Related PRs
WordPress-iOS
[Global Styles] Implement Global Styles endpoint WordPress-iOS#16411Gutenberg-Mobile
[Global Styles] Adds new Prop for Global Styles Settings gutenberg-mobile#3459Gutenberg
[RN Mobile][Global Styles] Adds new Prop for Global Styles Settings WordPress/gutenberg#30544Tests:
📓 This can be tested along side wordpress-mobile/WordPress-iOS#16411
Regression Tests:
These should be run on a site with "Global Style Settings" disabled or a site that doesn't have WordPress 5.8 installed:
Tests:
These should be run on a site with "Global Style Settings" enabled and a site that has WordPress 5.8 installed: