Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global Styles] Implement Global Styles endpoint #394

Merged
merged 19 commits into from
Jul 1, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Apr 29, 2021

Description

Fixes wordpress-mobile/gutenberg-mobile#3163
Related PRs

Tests:

📓 This can be tested along side wordpress-mobile/WordPress-iOS#16411

Regression Tests:

These should be run on a site with "Global Style Settings" disabled or a site that doesn't have WordPress 5.8 installed:

  • Default Colors - Check that default colors still load - steps
  • Default Gradients - Check that default gradients still load - steps
  • Custom Colors - Check that custom colors load in the editor - steps
  • Custom Gradients - Check that custom gradients load in the editor - steps
  • Offline Support - steps

Tests:

These should be run on a site with "Global Style Settings" enabled and a site that has WordPress 5.8 installed:

  • FSE Colors and Gradients - steps
  • Offline Support - steps

  • Please check here if your pull request includes additional test coverage.

@chipsnyder chipsnyder force-pushed the gutenberg/issue/3163-gss branch from d35233c to 6289cf3 Compare May 6, 2021 17:43
@chipsnyder chipsnyder requested review from antonis and geriux May 19, 2021 16:07
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Chip 👍
Tested this via the iOS PR and works as expected. The code also looks great 🎉

@chipsnyder chipsnyder force-pushed the gutenberg/issue/3163-gss branch from e91386b to cb854d7 Compare June 16, 2021 18:57
@chipsnyder chipsnyder marked this pull request as ready for review June 28, 2021 20:45
@chipsnyder chipsnyder merged commit ceaa585 into develop Jul 1, 2021
@chipsnyder chipsnyder deleted the gutenberg/issue/3163-gss branch July 1, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants