Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.103.0 #21476

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Integrate gutenberg-mobile release 1.103.0 #21476

merged 5 commits into from
Sep 1, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Aug 31, 2023 •
edited
Loading

Description

This PR incorporates the 1.103.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6139

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Aug 31, 2023
@geriux geriux mentioned this pull request Aug 31, 2023
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 31, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21476-56a1e54
Version23.1
Bundle IDorg.wordpress.alpha
Commit56a1e54
App Center BuildWPiOS - One-Offs #6940
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 31, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21476-56a1e54
Version23.1
Bundle IDcom.jetpack.alpha
Commit56a1e54
App Center Buildjetpack-installable-builds #5980
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux added this to the 23.2 milestone Aug 31, 2023
geriux
geriux commented Aug 31, 2023
View reviewed changes
Gutenberg/config.yml Outdated
#
# LOCAL_GUTENBERG=../my-gutenberg-fork bundle exec pod install
tag: v1.102.1
commit: 3025c34b5015f43884b697cb0cd80826c97138ce
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the release script removes the comments 🤔 I'll restore it back when I update the reference with the tag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this reference is not pointing to the latest commit of the Gutenberg Mobile PR, the SHA should be 273a193d6c0fcb05d09e1722902c8d985f089422. Nevertheless, since the commits pushed after this reference only introduce an E2E test fix and update the release notes, we could directly use the release Git tag once we merge the Gutenberg PRs.

@geriux geriux marked this pull request as ready for review August 31, 2023 14:52
@geriux
Copy link
Contributor Author

geriux commented Aug 31, 2023

FYI I'll fix the Release notes conflicts when I update the Gutenberg reference with the tag.

fluiddot
fluiddot reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me 🎊 ! I hold off on the approval until we update the release notes as mentioned here.

Gutenberg/config.yml Outdated
#
# LOCAL_GUTENBERG=../my-gutenberg-fork bundle exec pod install
tag: v1.102.1
commit: 3025c34b5015f43884b697cb0cd80826c97138ce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this reference is not pointing to the latest commit of the Gutenberg Mobile PR, the SHA should be 273a193d6c0fcb05d09e1722902c8d985f089422. Nevertheless, since the commits pushed after this reference only introduce an E2E test fix and update the release notes, we could directly use the release Git tag once we merge the Gutenberg PRs.

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

fluiddot
fluiddot approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@geriux geriux merged commit 09e5874 into trunk Sep 1, 2023
@geriux geriux deleted the gutenberg/integrate_release_1.103.0 branch September 1, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @wpmobilebot @fluiddot