Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling: Define SwiftLint version #350

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Tooling: Define SwiftLint version #350

merged 1 commit into from
Feb 26, 2024

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Feb 23, 2024 •
edited
Loading

This PR uses the newly added run-swiftlint command added to https://github.com/Automattic/a8c-ci-toolkit-buildkite-plugin (implemented on Automattic/a8c-ci-toolkit-buildkite-plugin#79).

The main changes:

  • Removal of the local .buildkite/commands/run-swiftlint.sh.
  • Setting the SwiftLint version in the .swiftlint.yml file.
  • Usage of the run-swiftlint command from a8c-ci-toolkit-buildkite-plugin, which will use the SwiftLint version.

Testing Details

Make sure CI is 🟢

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia requested a review from mokagio February 23, 2024 16:14
@iangmaia iangmaia self-assigned this Feb 23, 2024
@iangmaia iangmaia changed the title Set the SwiftLint version in .swiftlint.yml and use the common `run… Tooling: Define SwiftLint version Feb 23, 2024
@iangmaia iangmaia marked this pull request as ready for review February 23, 2024 16:16
mokagio
mokagio approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the SwiftLint output in CI. Thanks @iangmaia

.buildkite/pipeline.yml
notify:
- github_commit_status:
context: SwiftLint
context: "SwiftLint"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this came via copy-paste from the other projects that use the same step. Just wanted to point out that the "" are redundant. 😄

@iangmaia iangmaia merged commit a4179d3 into trunk Feb 26, 2024
10 checks passed
@iangmaia iangmaia deleted the iangmaia/swiftlint-version-ci branch February 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees

@iangmaia iangmaia

Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iangmaia @mokagio