Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dangermattic configuration #349

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Feb 20, 2024

Description

This PR adds Dangermattic to this repo.
My main goal was to add RuboCop, but I added some other basic checks as well.

Please let me know if it makes sense to add more checks seen in other repos (reference)

Testing Details

The main validation is to make sure CI is 🟢.

To run Danger yourself:

  1. Checkout this branch
  2. Run bundle install
  3. Run:
DANGER_GITHUB_API_TOKEN=<github_token> bundle exec danger pr <PR_URL>

You should get in the console the same errors / warnings reported in the PR.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia requested a review from mokagio February 20, 2024 15:02
@iangmaia iangmaia self-assigned this Feb 20, 2024
@crazytonyli crazytonyli merged commit 2dc7b5d into trunk Feb 20, 2024
9 checks passed
@crazytonyli crazytonyli deleted the iangmaia/dangermattic-setup branch February 20, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants