Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Improvements: Fix Feature Flag #15003

Merged

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Jul 8, 2021

Parent #14989
Relates to: #14997

This is a fix that relates to the #14997 PR where the BuildConfig was pointing to the wrong configuration.

To test:

Regression Notes

  1. Potential unintended areas of impact

N/A

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

See To test section above.

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

N/A

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for this quick fix!

Feel free to merge when CI completes.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@ashiagr ashiagr merged commit 8203f20 into develop Jul 9, 2021
@ashiagr ashiagr deleted the issue/14989-fix-onboarding-improvements-feature-flag branch July 9, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants