Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2단계 - 경로 조회 기능] 테오(최우성) 미션 제출합니다. #161
[2단계 - 경로 조회 기능] 테오(최우성) 미션 제출합니다. #161
Changes from 35 commits
2ae9c7f
deaa0b7
07236eb
865285c
ba2fe46
e88520c
2a074b6
358c719
3d57ba3
85cf081
355093a
d9a0a43
a5846d3
8cb28a2
0a8c562
5755cce
deb3904
ff7a588
436df91
87fba10
8462216
a1841b4
c3cc929
18406a6
4b4ba7d
b065df8
fab2161
55ebc2a
24f3558
74ae079
07ab84f
3ff06bc
a55a7cc
8697f4a
77cef32
c2d164e
2c6abba
caf3f04
9f3601e
2ff9d56
17a5215
9126f5d
b0d4709
13ee83e
4fae785
05d3183
eb7e1f0
c294bd5
4ffbe88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
((int) distance -1) / (int) referenceDistance)
는 int / int 인데 나눗셈 과정에서 발생할 수 있는 문제는 없을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 남겨주신거 보긴 했는데 테코톡 + 미션으로 바빠 이제 코멘트를 남기네요! 🥲
int / int 나눗셈으로 인해 distance가 0.9이든, 0.0이든 동일시되는 문제가 발생할 것 같습니다.
요금 정책이 해당 계산식이라 저렇게 구성한 것이긴 한데,
거리가 X.5KM 이상이면 반올림해서 계산한다
등의 비즈니스 규칙을 따로 정의하고 수식을 바꿔도 괜찮을 것 같네요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시간이 되신다면 전에 언급주신 것처럼 Exception도 �어느 정도 계층화를 시도해보면 좋겠습니다~
DatabaseException, NetworkException을 두는 방법도 있고 각 계층마다 exception 패키지를 따로 두는 방법도 있습니다. 연습할 때는 전자를 추천드립니다.