[3단계 - 체스] 테오(최우성) 미션 제출합니다. #536
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,67 +1,106 @@ | ||
| package controller; | ||
|
|
||
| import controller.adapter.inward.Command; | ||
| import controller.adapter.inward.CommandArguments; | ||
| import controller.adapter.inward.CoordinateAdapter; | ||
| import controller.adapter.outward.RenderingAdapter; | ||
| import domain.board.ChessGame; | ||
| import domain.piece.move.Coordinate; | ||
| import view.InputView; | ||
| import view.OutputView; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.function.BiConsumer; | ||
|
|
||
| public class ChessController { | ||
|
|
||
| public static final int START_COORDINATE_INDEX = 1; | ||
| public static final int END_COORDINATE_INDEX = 2; | ||
|
|
||
| private final InputView inputView; | ||
| private final OutputView outputView; | ||
|
|
||
| private final Map<Command, BiConsumer<ChessGame, CommandArguments>> commander; | ||
|
|
||
| public ChessController( | ||
| final InputView inputView, | ||
| final OutputView outputView | ||
| ) { | ||
| this.inputView = inputView; | ||
| this.outputView = outputView; | ||
| this.commander = new HashMap<>(); | ||
| initializeCommander(); | ||
| } | ||
|
|
||
| private void initializeCommander() { | ||
| commander.put(Command.START, this::start); | ||
| commander.put(Command.END, this::end); | ||
| commander.put(Command.MOVE, this::move); | ||
| commander.put(Command.STATUS, this::status); | ||
| } | ||
|
|
||
| public void run() { | ||
| ChessGame chessGame = setupGame(); | ||
| repeat(() -> interact(chessGame)); | ||
| printGameResult(chessGame); | ||
| } | ||
|
|
||
| private ChessGame setupGame() { | ||
| ChessGame chessGame = new ChessGame(); | ||
| outputView.printGameStartMessage(); | ||
| return chessGame; | ||
| } | ||
|
|
||
| private void repeat(Runnable target) { | ||
| try { | ||
| target.run(); | ||
| } catch (IllegalArgumentException e) { | ||
| outputView.printExceptionMessage(e.getMessage()); | ||
| repeat(target); | ||
| } | ||
| } | ||
|
|
||
| private void printGameResult(final ChessGame chessGame) { | ||
| String gameResultMessage = RenderingAdapter.unpackGameResult(chessGame.collectPoint()); | ||
| String winningColorMessage = RenderingAdapter.convertWinningColor(chessGame.getWinningColor()); | ||
| outputView.printGameResult(gameResultMessage); | ||
| outputView.printWinner(winningColorMessage); | ||
| } | ||
|
|
||
| private void interact(final ChessGame chessGame) { | ||
| Command command; | ||
| do { | ||
| List<String> pureArguments = inputView.readCommand(); | ||
| command = Command.of(pureArguments); | ||
| CommandArguments commandArguments = CommandArguments.of(pureArguments); | ||
| commander.get(command).accept(chessGame, commandArguments); | ||
| } while (command.isNotEnd() && chessGame.isGameNotOver()); | ||
| } | ||
|
|
||
| private void start(final ChessGame chessGame, final CommandArguments ignored) { | ||
| printBoard(chessGame); | ||
| } | ||
|
|
||
| private void end(final ChessGame chessGame, final CommandArguments ignored) { | ||
| printGameResult(chessGame); | ||
| } | ||
|
|
||
| private void move(final ChessGame chessGame, final CommandArguments arguments) { | ||
| Coordinate startCoordinate = CoordinateAdapter.convert(arguments.getArgumentOf(START_COORDINATE_INDEX)); | ||
| Coordinate endCoordinate = CoordinateAdapter.convert(arguments.getArgumentOf(END_COORDINATE_INDEX)); | ||
|
Comment on lines
+91
to
+92
There was a problem hiding this comment. arguments를 별도의 일급 컬렉션으로 뺀 부분이 매우 좋았습니다. 물론 이부분은 이견이 있을 수 있으므로, 자유롭게 의견 적어주시고 반영 여부 결정해주세요 👍 There was a problem hiding this comment. 동의합니다 👍👍 좌표계 변환 자체를 완전히 Arguments의 책임으로 변경해볼게요! |
||
| chessGame.move(startCoordinate, endCoordinate); | ||
| printBoard(chessGame); | ||
| } | ||
|
|
||
| private void status(final ChessGame chessGame, final CommandArguments ignored) { | ||
| outputView.printGameStatus(RenderingAdapter.unpackGameResult(chessGame.collectPoint())); | ||
| printBoard(chessGame); | ||
| } | ||
|
|
||
| private void printBoard(final ChessGame chessGame) { | ||
| String boardMessage = RenderingAdapter.unpackBoard(chessGame.getBoard()); | ||
| outputView.printBoard(boardMessage); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package controller.adapter.inward; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public class CommandArguments { | ||
|
|
||
| private final List<String> arguments; | ||
|
|
||
| private CommandArguments(final List<String> arguments) { | ||
| this.arguments = arguments; | ||
| } | ||
|
|
||
| public static CommandArguments of(final List<String> arguments) { | ||
| return new CommandArguments(arguments); | ||
| } | ||
|
|
||
| public String getArgumentOf(final int index) { | ||
| if (index < 0 || index >= arguments.size()) { | ||
| throw new IllegalArgumentException("[ERROR] 명령 인자가 존재하지 않습니다."); | ||
| } | ||
| return arguments.get(index); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이부분을 독특하게 작성해주셨네요!
commander 클래스를 별도로 만들어줘야 한다는 점에서 조금 걸리긴 하나,
구조 개선에 있어서는 역할을 분명히 한다는 생각도 듭니다. 일단 유지해 봅시다 👍