-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor using typescript, while supporting esm/cjs #24
Conversation
…ototype.repeat()` instead of `repeat-string` npm package
…ify tsconfig to support default import
…sm at the same time
…generated by the IDE and the dist directory generated after packaging
…semantics of the typescript code, ref: https://i.loli.net/2021/05/10/DNMBkgts9bmP2hO.png
…ring mode, which causes the process to fail to end, and transfer it to the dev script
Appreciate you working on
Your fix of duplicate |
Why? This will cause it to explode when used in jest tests(I used import), and it is not difficult to support cjs. . .
Obviously, .d.ts is already provided in the project, why not refactor to ts in one go? Again, this is not a trouble, my modification is only to add |
Because I also had all my projects in CoffeeScript and its a ton of work to change language every couple of years. |
jest esm support is not complete, I will re-release a new package... |
The specific changes are as follows
xo --fix
from the format command, it will change the semantics of the typescript code, ref、String.prototype.repeat()
instead ofrepeat-string
npm package