Skip to content

Commit

Permalink
release_tag hernoemd naar release
Browse files Browse the repository at this point in the history
  • Loading branch information
sTomerG committed Jul 12, 2024
1 parent e450348 commit e1a599a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ testframework.test(
test=ReferentiedataTest(
soort="RUIMTEDETAILSOORT",
attribuut="Code",
release_tag="latest", # standaard is latest, maar kan ook een specifieke versie zijn zoals v4.1.240419
release="latest", # standaard is latest, maar kan ook een specifieke versie zijn zoals v4.1.240419
),
nullable=False, # of een waarde leeg mag zijn. Dit is aan de gebruiker
).show()
Expand Down
10 changes: 5 additions & 5 deletions src/vera_testframework/pyspark/referentiedata.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ReferentiedataTest(ValidCategory): # type: ignore
name (Optional[str]): The name of the test. If not provided, defaults to "VERAStandaard".
soort (str): The type/category of the data, which will be converted to uppercase.
attribuut (Literal["Code", "Naam"]): The attribute to use, either "Code" or "Naam". It will be capitalized.
release_tag (str): The tag of the release to use. Default is "latest".
release (str): The tag of the release to use. Default is "latest".
Raises:
TypeError: If soort is not a string.
Expand All @@ -28,7 +28,7 @@ def __init__(
name: Optional[str] = None,
soort: str,
attribuut: Literal["Code", "Naam"],
release_tag: str = "latest",
release: str = "latest",
):
if not isinstance(soort, str):
raise TypeError("soort must be a string")
Expand All @@ -40,9 +40,9 @@ def __init__(

name = name if name else "VERAStandaard"

self.referentiedata = self._get_cached_data(release_tag)
self.referentiedata = self._get_cached_data(release)
super().__init__(name=name, categories=self._categorieen())
self.release_tag = release_tag
self.release = release

@classmethod
def _get_cached_data(cls, release_tag: str) -> list[dict[str, str]]:
Expand All @@ -65,7 +65,7 @@ def _categorieen(self) -> set[str]:
return {row[self.attribuut] for row in categorieen_rows}

def __str__(self) -> str:
return f"ReferentiedataTest({self.soort}, {self.attribuut})"
return f"ReferentiedataTest({self.soort}, {self.attribuut}, {self.release})"

def __repr__(self) -> str:
return self.__str__()
2 changes: 1 addition & 1 deletion tests/pyspark/referentiedata/test_ReferentiedataTest.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,5 @@ def test_str_and_repr():
def test_wrong_release_tag():
with pytest.raises(Exception):
ReferentiedataTest(
soort="RUIMTEDETAILSOORT", attribuut="Code", release_tag="invalid"
soort="RUIMTEDETAILSOORT", attribuut="Code", release="invalid"
)
2 changes: 1 addition & 1 deletion tutorial.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
" test=ReferentiedataTest(\n",
" soort=\"RUIMTEDETAILSOORT\",\n",
" attribuut=\"Code\",\n",
" release_tag=\"latest\", # standaard is latest, maar kan ook een specifieke versie zijn zoals v4.1.240419\n",
" release=\"latest\", # standaard is latest, maar kan ook een specifieke versie zijn zoals v4.1.240419\n",
" ),\n",
" nullable=False, # of een waarde leeg mag zijn. Dit is aan de gebruiker\n",
").show()"
Expand Down

0 comments on commit e1a599a

Please sign in to comment.