Fix For Unexpected Behaviour When To-One Relationship Data Is NULL - Closes #7 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…many relationship
…elationship::createFromArray()
|
@kocsismate That's strange... Travis says a specific test fails relating to the changes I made, but PHPUnit on my local doesn't through any errors. Do you want me to update the |
|
I'll take care of the tests, thank you :) And I'll get back to you when I release the new versions with your fix. |
kocsismate
pushed a commit
that referenced
this pull request
Nov 17, 2017
…loses #7 (#8) * Fixed to-one relationships with null data being returned as empty to-many relationship * Fixed toArray() not returning expected ['data' => null] in nullable relationships * Changed is_null to identical comparison when checking for 'data' in Relationship::createFromArray() * Applying fixes for StyleCI
|
I managed to fix the problem, but it was a bit more tricky than I thought. :) Furthermore, I have just cherry-picked our commits to the 1.2 branch. So I'd like to ask you to test it. If all is good, then I'll release 1.2.1 and 1.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see issue #7 for full information.
JSONAPI spec states to-one relationships with no associated resource should return
{"data": null}but Yang does not properly account for this when convertingRelationshipto an array. This pull request fixes Yang returning an empty to-many relationship (['data' => []]) instead of an empty to-one relationship (['data' => null]).