Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PSR interface #34

Merged
merged 3 commits into from
Oct 17, 2021

Conversation

fs613fs
Copy link
Contributor

@fs613fs fs613fs commented Oct 11, 2021

Implemented PSR interface for JsonApiClient

@kocsismate
Copy link
Member

Hi!

Thanks for the PR! However, the problem is that the current stable version (Yang 2.x) is still compatible with 7.2 where the return type variance is not supported, so the JsonApiResponse return type is not compatible with PSR-18's ResponseInterface.

Fortunately, Yang 3.0 is still in the works, and it requires PHP 7.4 at least, where variance is supported. So please change the target branch from master to 3.0.

@fs613fs fs613fs changed the base branch from master to 3.0 October 15, 2021 13:55
@fs613fs
Copy link
Contributor Author

fs613fs commented Oct 15, 2021

Hi kocsismate,

Thank you for the comments. I have changed the target branch to 3.0.

@kocsismate
Copy link
Member

Looks like there's a conflict. Can you please resolve it before I merge the PR?

@fs613fs
Copy link
Contributor Author

fs613fs commented Oct 15, 2021

Looks like there's a conflict. Can you please resolve it before I merge the PR?

done. thanks

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #34 (d069dc5) into 3.0 (dba8652) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.0      #34   +/-   ##
=========================================
  Coverage     97.84%   97.84%           
  Complexity      480      480           
=========================================
  Files            28       28           
  Lines          1019     1019           
=========================================
  Hits            997      997           
  Misses           22       22           
Impacted Files Coverage Δ
src/JsonApi/Client/JsonApiClient.php 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba8652...d069dc5. Read the comment docs.

@kocsismate kocsismate merged commit bba98b2 into woohoolabs:3.0 Oct 17, 2021
@kocsismate
Copy link
Member

Thank you for the PR! I'll try to release the change in the coming week(s).

@kocsismate
Copy link
Member

I've just released 3.0.0-beta1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants