-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PSR interface #34
Conversation
Hi! Thanks for the PR! However, the problem is that the current stable version (Yang 2.x) is still compatible with 7.2 where the return type variance is not supported, so the Fortunately, Yang 3.0 is still in the works, and it requires PHP 7.4 at least, where variance is supported. So please change the target branch from |
Hi kocsismate, Thank you for the comments. I have changed the target branch to 3.0. |
Looks like there's a conflict. Can you please resolve it before I merge the PR? |
done. thanks |
Codecov Report
@@ Coverage Diff @@
## 3.0 #34 +/- ##
=========================================
Coverage 97.84% 97.84%
Complexity 480 480
=========================================
Files 28 28
Lines 1019 1019
=========================================
Hits 997 997
Misses 22 22
Continue to review full report at Codecov.
|
Thank you for the PR! I'll try to release the change in the coming week(s). |
I've just released 3.0.0-beta1 :) |
Implemented PSR interface for JsonApiClient