Merge pull request #29 from holtkamp/patch-attribute-hydrator-interface

Introduce AttributeHydratorInterface

phpstan.neon

@@ -8,11 +8,13 @@ parameters:
         -
             message: '#^Access to an undefined property object::.*$#'
             paths:
-                - '%currentWorkingDirectory%/src/JsonApi/Hydrator/ClassDocumentHydrator'
+                - '%currentWorkingDirectory%/src/JsonApi/Hydrator/AttributeHydrator'
                 - '%currentWorkingDirectory%/tests/JsonApi/Hydrator/ClassDocumentHydratorTest'
         -
             message: '#^Variable property access on object\.$#'
-            path: '%currentWorkingDirectory%/src/JsonApi/Hydrator/ClassDocumentHydrator'
+            paths:
+                - '%currentWorkingDirectory%/src/JsonApi/Hydrator/AttributeHydrator'
+                - '%currentWorkingDirectory%/src/JsonApi/Hydrator/ClassDocumentHydrator'
         - '#^Dynamic call to static method PHPUnit\\Framework\\.*$#'
         -
             message: '#^.*$#'

src/JsonApi/Hydrator/AttributeHydrator.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WoohooLabs\Yang\JsonApi\Hydrator;
+
+use WoohooLabs\Yang\JsonApi\Schema\Resource\ResourceObject;
+
+class AttributeHydrator implements AttributeHydratorInterface
+{
+    public function hydrateResourceAttributes(object $result, ResourceObject $resource): object
+    {
+        $result->type = $resource->type();
+        $result->id   = $resource->id();
+        foreach ($resource->attributes() as $attribute => $value) {
+            $result->{$attribute} = $value;
+        }
+
+        return $result;
+    }
+}

src/JsonApi/Hydrator/AttributeHydratorInterface.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WoohooLabs\Yang\JsonApi\Hydrator;
+
+use WoohooLabs\Yang\JsonApi\Schema\Resource\ResourceObject;
+
+interface AttributeHydratorInterface
+{
+    public function hydrateResourceAttributes(object $result, ResourceObject $resource): object;
+}

src/JsonApi/Hydrator/ClassDocumentHydrator.php

@@ -11,6 +11,16 @@
 
 class ClassDocumentHydrator extends AbstractClassDocumentHydrator
 {
+    /**
+     * @var AttributeHydratorInterface
+     */
+    private $attributeHydrator;
+
+    public function __construct(?AttributeHydratorInterface $attributeHydrator = null)
+    {
+        $this->attributeHydrator = $attributeHydrator ?? new AttributeHydrator();
+    }
+
     /**
      * @return object[]
      */
@@ -39,13 +49,7 @@ protected function createObject(ResourceObject $resource): object
 
     protected function hydrateResourceAttributes(object $result, ResourceObject $resource): object
     {
-        $result->type = $resource->type();
-        $result->id = $resource->id();
-        foreach ($resource->attributes() as $attribute => $value) {
-            $result->{$attribute} = $value;
-        }
-
-        return $result;
+        return $this->attributeHydrator->hydrateResourceAttributes($result, $resource);
     }
 
     protected function hydrateResourceRelationship(object $result, Relationship $relationship, string $name, object $object): object