[pull] master from project-chip:master #646
Open
+115,235
−58,741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup zap templates * Update whitespace
* Decouple ember functions from general diagnostics cluster * Optimize flash cost * Add compile flag for each command * Address review comments
* Add conditions to renegotiate ble connection intervals * Update src/platform/silabs/efr32/BLEManagerImpl.cpp
…36907) * Fix icdm 2.1 test case without uat * update CI * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Clean up Wifi Interface headers * Rename SiWx function * fix comment * fix build * Address review comments
…ram savings, simpler interface (#37033) * Copied over the new AttributePathExpandIterator and will incrementally use it (so I can validate tests) * Rename AttributePathExpandIterator to legacy * Prepare for using new style iterators ... checking NOT YET enabled though * Enabled checks ... and unit tests fail, but this now can be debugged * Fix some of the underlying bugs: read handling logic assumes we are ok to undo * Unit tests pass now * Restyle * Use new iterator in IME * Update logic to use the new iterator on testRead * more updates * Restyle * Remove the legacy attribute path expand iterator * Update naming * Restyle * Remove extra argument for ReadHandler constructor * Restyle * Slight flash improvement * Fix up includes * Removed empty line * added comment on why state is a friend class * Comment updates * Restyle, add some comments and add extra checks on validity check only for expansion. This saves a tiny amount of flash (32 bytes) * Remove an include * Comment updates, renamed mLastOutputPath to mOutputPath * Fix one typo * Re-arrange members of ReadHandler to optimize for memory layout. This saves 8 bytes for struct. We still have a 20-byte padding which I am unsure how to get rid of * Restyle * Rename State to Position * One more rename * Remove redundant assigment ...we are at a net 0 txt increase now on qpg * Add more unit tests for non-obvious requirement that wildcard expansion checks path validity, however non-wildcard does not check it * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/ReadHandler.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/ReadHandler.cpp Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * Use different values for the cluster ids for testing * One more state to position change * mExpanded is now set during output path returning. Removed 2 more sets to save another tinier amount of .text * Import metadatalist class and test * Remove some tests that seem redundant, keep only one * Start with generated commands, see if we can replace its usage... * Unit tests for GeneratedCommands pass * Start with an implementation of accepted commands (no testing yet) * More tests pass * Updated AcceptedCommands as well .. unit tests pass * Restyle * Fix namespaces * Slight refactor. Code is still very much ugly * A bit of refactor, code looks better and tests pass now * Code compile for semantic tag ... made std::optional support non-trivial destructors * Update test * Make chip::Optional be trivially destructible if the underlying type is. Previous implementation always had a destructor, so it was never trivially destructible. * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/InteractionModelEngine.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/ReadHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/ReadHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Use mCompletePosition * Another rename * Undo submodule update * Restyle * Remove extra char * Remove unused variable * Update comment text to not sound like graph parsing * Rename method to be more descriptive * Remove one more unused variable * Update peek attribute iterator to rollback and update code logic a bit. Hoping for cleaner code * Semantic tags conversion is done * Restyle * Migrate device types to the new format * update comment a bit * Add unused marker for chip errors used for logging only * Fix descriptor cluster * Fix microwave oven * Restyle * Fix intentional bugprone-use-after-move * Fix intentional bugprone-use-after-move * Restyle * Fix based on clang feedback * Move endpoints to the new style of iteration * Fix includes * Fix includes * Fix includes * make it standard that test Providers are for now CodegenDataModelProvider. Saves me some typing as I move things around * Restyle * Minor update in logic: do the endpoint selection when next is called * Allow startup to try to mark attributes dirty even if no provider exists yet * Fix typo * start implementing client clusters * Update ClientCluster logic * Restyle * Start defining the server cluster query * Actually use the new server cluster functionality * Fix an include * More include fixes * implement the get attributes and adapt unit tests * Restyle * more updates to cleanup code. I am a bit concerned about O(n^2) attribute access... * A rename and moved finder methods out of inline. Saves 650 bytes of flash * Update logic to centralize metadata list code with less templating * move the generic metadata list to detail, add an assert on trivial destruction * Fix namespace prefix * Save 70 bytes by using references in condensed for loops * Replace count-if because it seems to result in smaller code (46 bytes) * Another find_if replacement * Replaced some find_if...we are down to 92 bytes on qpg * Replaced one more find-if, saving another 88 bytes of flash * Removed algorithm includes: these are slow and would like compile to fail if used * Save more flash ... we should be at a net negative now * This seems to save even more * More savings by more encode overrides ... this is silly... * Fix typos * More explicit casting, removed 64-bit overrides * Added one more check for freeing memory .Still need to track a leak that darwin finds * Fix memory leak in assignment * Self-review: fix includes * Self-review: fix includes * Self-review: fix includes * Self-review: fix includes * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/descriptor/descriptor.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataList.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix spelling for acquire * Update src/app/data-model-provider/MetadataList.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataList.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataList.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix is_trivially_destructible * Update src/app/data-model-provider/MetadataSearch.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * More fixes * Fix includes * Fix invalid check typo * Fix comment * Correct comment * Updated comment * Make logic between clusters/attributes/endpoints the same regarding nullopt and wildcards * Restyle * Update logic for IsDescentantof * Help compiler generate efficient code as we keep reusing the same pointer * clearer logic that we handle all cases * Fixes * Use calloc * Update comment * Fix include * Fix casting * Make cluster count functions from ember public API since they seem reusable * Also fix dynamic dispatch * update enumeration entry * another comment update * Undo submodule update * Rename metadata search to metadta lookup * Update metadata list methods to be all uppercase * Fix more renames * Fix invalid cast * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/data-model-providers/codegen/CodegenDataModelProvider.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataList.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Address comments * fix bug * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * Update src/app/WriteHandler.cpp Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * Update src/app/AttributePathExpandIterator.cpp Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com> * Restyle and include update --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Mathieu Kardous <84793247+mkardous-silabs@users.noreply.github.com>
* Add support for ExtraReadPaths to CommissioningParameters * CHIP_CONFIG_ENABLE_READ_CLIENT strikes again * Check for alloc failure * Address further review comments
* Remove cluster objects dependency from platform * Add a dependency that was transient before * More updates, get up to qpg to compile * Restyle * Add app_config dependency to all ThreadStackManagerImpl.cpp * Fix one more compile error * Make ConnectivityManagerImpl.cpp depend on app_config * One more dependency for InteractionModelEngine.h * Fix AccessRestrictionProvider dependencies * Workaround for ESP32 layering error
Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
* [Telink] Manual Zephyr SDK update to check CI jobs * [Telink] Update Zephyr revision & remove dev changes * typo
* Fix regular expression for variable splitting. Previous code tried to escape every character, however python linters complained about illegal escapes. The expression also seemed a bit complex, so a character set seems clearer. * Add brackets to force separator to also exist in the split
…7498) Add additional test steps to verify TC-related attributes before sending CommissioningComplete: - Verify TCAcceptedVersion equals 0 - Verify TCAcknowledgements equals 0 - Verify TCAcknowledgementsRequired equals True
…`-fcoverage-mapping/-fprofile-instr-generate` (#37457) * Add coverage support flags (but no save yet for the flag) * Minor cleanup, save config options when loading variants, so build flags transcend running * Fix yaml content * Restyled by isort * Switch coverage to clang, ensure out dir for config exists * Slight doc update, allow local.py to use ccache * Start adding filter support and comma separation support to local.py * Fix the runner termination logic * gen-coverage works * Restyle * make linter happy * Make it clearer what errors we ignore, add more error logic to make this run on more machines * Restyle * Add more ignores for cleaner results * Restyle * One more ignore * Better organization, make paths consistent * Fix logic. Merged reports now work! * Restyle * fix stderr logging * fix fail dir creation * Make mismatched FIFO pid much easier to investigate * Add hierarchical view by default - it seems easier for us to narrow down coverage * Add coverage support for yaml * Use exec to execute the sub-program * Fix up arguments in local.py to support propper quoting * For chip tool tests also run chip-tool with coverage support * Fix the path-variance runs of unit test, so I can run unit tests with coverage * Updated comment a bit * Increase timeout for test running to cover slow tests, skip slow tests or tests that we know will fail * Also exclude manual tests by default from local runs * match default exclusions ... also flaky excluded * Support keep going for yaml tests, add more ignores * Multiprocessing coverage, coverage now works * Add missing assignment * Restyled by autopep8 --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
…37506) * [Darwin] Support MTRCommandWithRequiredResponse being nested in XPC When secure decoding MTRCommandWithRequiredResponse as part of [MTRDevice deviceController:nodeID:invokeCommands:completion:], it needs to list all classes that be part of the commandFields and requiredResponse fields. When double nested XPC will only assume to decode NSDictionary of basic type. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Initial generated test * Fixed and compared against test plan * Remove unused TC-TSTAT-2.2 yaml * Apply suggestions from code review Co-authored-by: fesseha-eve <88329315+fessehaeve@users.noreply.github.com> * Update TC_TSTAT_2_2.py fixed below mentioned discrepancies on the code: Step-3c: The test plan expects a Success response, but the script is checking for a ConstraintError. If the value does not violate any conditions, the response should be Success. In such cases, the test will fail. Step-4c: If the AUTO feature is enabled, the script writes the UnoccupiedCoolingSetpoint attribute with MaxCoolSetpointLimitValue and checks for a ConstraintError response, which is not required. Step-5c: The script should check the following condition when the AUTO feature is enabled: Min(MaxHeatSetpointLimit, (UnoccupiedCoolingSetpoint - MinSetpointDeadBand)). However, this condition is missing in the script, and it incorrectly checks for a ConstraintError response. Step-7a: The write and read verification is missing. Step-9b: The script incorrectly writes the attribute value using AbsMinCoolSetpointLimitValue instead of MinCoolSetpointLimitValue. Step-9c: A duplicate read check has been removed. * Python linter fix for TC_TSTAT_2_2 * Update src/python_testing/TC_TSTAT_2_2.py Co-authored-by: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com> * Restore setpoints to original values at end of test * Use get_endpoint method to find active endpoint * Update CI Test Arguments to the apparent new style --------- Co-authored-by: fesseha-eve <88329315+fessehaeve@users.noreply.github.com> Co-authored-by: Kishok G <133193761+KishokG@users.noreply.github.com> Co-authored-by: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com>
…cker version 112 (#37356) * [Telink] simplify WS2812_STRIP config * [Telink] Fix targets configs * [Telink] Use HAL mac_init functions directly * [Telink] disable PM for window app * [Telink] Fix Zephyr warning & use k_work_delayable_from_work * [Telink] Remove duplicate config * [Telink] clean-up Kconfig files * [Telink] clean-up enable-gnu-std.cmake * [Telink] Remove continue-on-error * [Telink] Fix/Enable BLE optimization * [Telink] Optimize MCUBoot log level configs * [Telink] use common SOC configs for different Zephyr versions * [Telink] Change Window Covering App default SoC W91 doesn't support PM * [Telink] Reduce mcuboot partition size * [Telink] Use 4mb flash for B92 till driver sdk update * [Telink] B92 update * [Telink] Remove temp b92 4mb change * [Telink] Update Zephyr revision * [Telink] Update builds to docker version 112 * Keep [Lint Code Base] image on version 98 Keep [Smoke test - Android] image on version 108 * Keep [Java Tests] image on version 104
…dling (#37322) * Move write validity inside the write handler rather than requesting the datamodel provider to perform the checks * Restyle * A bit of code cleanup and reuse, to minimize flash impact * Restyle * Drop the mPreviousSuccessPath, making objects smaller and saving yet another small amount of flash * Cleanup some includes * Restyle * Remove obsolete tests from codgen, as we do not do more validation now * Test write interaction passes * Test write passes * Slight clarity of code update * Fix comment * Manual check for last written saves 16 bytes of flash on QPG. * Status success is 2 bytes smaller in code generation than CHIP_NO_ERROR * Not using endpoint finder saves flash * Clean up code. We now save flash * More flash savings by reusing the server cluster finder * Update src/app/data-model-provider/MetadataLookup.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/Provider.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/data-model-provider/MetadataLookup.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Updated comment * Hoist "writing" log up in processing, to preserve similar functionality * Code clarity updates * Fix includes and update the code AGAIN because it does seem we use more flash * Fix unsupported write on global attributes * Fix includes * Update src/app/WriteHandler.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Post merge cleanup * Fix merge error --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Also logs the SSID when doing commmissioning onto a Wi-Fi network.
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Correct spelling of "toggle" in README. Signed-off-by: Maddy Marsh <m-marsh@ti.com>
…37453) - Add optional `allow_empty` parameter to control empty list validation - Reorder function parameters for better readability - Update function docstring to clarify new behavior - Update test cases
* Fix line endings for master DM XMLs * Add newline at end of file for master DM XMLs * Add closures as a file exception - device types all in one file * DM XMLs: Update master to 0.7 of 1.5 and use alchemy Note that this contains a significant number of changes in one commit, and I apologise for that, but the new spec cannot be scraped with the DM editor, so I needed to swap to alchemy to get the new spec scraped. Hence this contains both the alchemy formatting changes (as outlined in #37201 as well as the changes from the last ballot to the current ballot. * Update file list in build file * Fix unit tests to expect clusters removed in 1.5 * Update device type parsing to warn on non-int IDs rather than failing This happens on ID-TBD in the ballot. * Add test to ensure all spec device types are OK. * Add a stringifier to XmlFeature XmlCommand * Restyled by autopep8 * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
#37454) * [bouffalo lab] update scripts and documents to support more options to generate and download test mfd * Restyled by prettier-markdown * Restyled by autopep8 * Restyled by isort * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
#37516) * [bouffalolab] update macro define for header reserve size and ethernet zap configuration * re-generate lighting-app-ethernet.matter
…7517) * [bouffalo lab] open commission window when last fabric is removed * Restyled by whitespace * fix compile error --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Darwin] Add logging for sync storage duration over a threshold * restyled * Clarify constant name per review comment
ReadClient does this, but we are not using its backoff logic.
* update android sdk version * Update full-android.yaml * Update smoketest-android.yaml * Update smoke-test.yaml * Update full-android.yaml * Update smoketest-android.yaml * Update smoke-test.yaml * Update java-tests.yaml * Update android_building.md * Update README.md * Restyled by prettier-markdown * Update full-android.yaml * Update java-tests.yaml * Update smoketest-android.yaml * Update smoke-test.yaml * Update smoketest-android.yaml * Update full-android.yaml * update java_path with java_home --------- Co-authored-by: Restyled.io <commits@restyled.io>
…37455) * [bouffalo lab] fix wifi scan issues and update some platform changes * Restyled by clang-format * Restyled by gn * Restyled by clang-format * fix wifi scan on bl706 + bl602 platform * Restyled by whitespace * Restyled by clang-format * use strncpy to copy ssid * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* esp32: Fix incorrect RTC log format in SystemTimeSupport * esp32: used strftime for formatting
* Update Revision versions * Remove unnesesary clusters * Remove unconformant extension * Added OTA-Requestor device type * Update Device Versions * Remove Switch Cluster * Changing device type to ColorTemperature Light The code is written to expect color changing, rather than removing the device type it makes more sense to change it into Color Temperature Light which suports the Color cluster
) Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.1 to 44.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.1...44.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )