[pull] master from project-chip:master #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RPC Event Service draft
* Commit the draft to add_event in post attr change
Commit the draft to add_event in post attribute change callback
* Add PreAttributeChangeCallback
* Support write events as string through RPC
* Revert Chef stubs.cpp to not using AttributeDelegate
* RPC can call delegate to SwitchManager/EventHandler
* Rmove ununsed RPC command delegate
* Rename RPC Event to RPC Actions
* Simplify RPC code by setting transparent subscribe
* Chef RPC Actions Draft done.
TBD:
Debug
Optimize
Error code
Confirm timer is ms
* Fix timer bug, remove unused comments
* Add Latching Switch taglist to Descriptor Cluster
* Cross platform built on ESP32/nRFConnect done
And also enable the ApplicationInit
* Update Generic Switch 1
* Add 2nd Generic Switch
* Add chef/common/chef-descriptor-namespace.h
* Remote printf
* Remove TODO
* Remove unused comments
* Restyled by whitespace
* Restyled by clang-format
* Fix according to PR comments
#33255
* Restyled by clang-format
* Fix compilation issues
* Remove unused debugging codes
---------
Co-authored-by: Restyled.io <commits@restyled.io>
…performed (#33598) Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* Define a EncodeToTLV inteface for the command handler * Slight documentation update * Comments update
* Linux: Guard mallinfo() use behind check for __GLIBC__ * Use positive checks for __GLIBC__ rather than ifndef
…3558) * XML file changes to remove apiMaturity="provisional" for clusters and features which are approved in Matter 1.3 * Removed stray text. * Updated after regen_all
… as chip-tool. (#33633) The commands now take a bit longer to time out on the exchange level, so we were hitting the test timeout.
#33604) We're actually hitting random failures where the apps get started, but over 15 minutes pass before the test tries to commission them, which causes them to close their commissioning windows, which makes the test fail. The fix is to just start the apps right when we're about to need them.
…interaction-model (#33595) * Initial version of splitting out command handler dependencies * Restyle * move privilege-storage based on dynamic server build rules...this is somewhat messy * More dynamic server fixes * Another gn fix for android/dynamic-server builds --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
…32516) * setup_payload: Add support for parsing setup payloads in python impl - Base38 decode impl in python - use construct to generate/parse setup payload in python - Add cli to parse and generate using click - unit tests for parsing and verification using chip-tool - removed the older script which only generated the codes - replaced the usage of older utility with newer one * Restyled by isort * fix the requirements * Added some test dataset * always use latest bitarray --------- Co-authored-by: Restyled.io <commits@restyled.io>
This adds support for an `optional` property to the `pkg_config` template.
…33639) chip-tool has one, and this will make it easier to use in YAMLs that run in both.
And specifically pick up new Tizen build container for qemu for #33628
* Several updates: comments and remove inline * Restyle * Move TryAddResponseData into the cpp instead of the header * Add override, virtual was a copy and paste * Name argument * Argument renaming and comment update * Move EncoderToTLV into DataModel as it looks like a more generic place, maybe we end up re-using it * Restyle * Update copyright year * Renames based on review comments * More renames of args * Fix compile * Slight comment update * More comment update after self-review * More comment update after self-review * Some renaming * Restyle * One more rename: EncodableType * EncodeTo should be const
Use of atomic builtins (__atomic_*) can require -latomic depending on what gets inlined (or not) on a particular platform.
* Fix issue related to teardown of some App Tests * Update comment Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* scraper updates re-write this msg * Restyled by isort --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Darwin] MTRDeviceConnectivityMonitor stopMonitoring crash fix * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…33674) * Darwin: Keep MTRCommissionableBrowser around until OnBleScanStopped Because the BLE platform implementation uses a separate dispatch queue, StopBleScan() does not synchrnously stop any further use of the current BleScannerDelegate. Keep the MTRCommissionableBrowser that contains the delegate alive until OnBleScanStopped to avoid a UAF. * restyle * Retain owner in Stop() instead of Start() * More review comments
* Implement StringToUUID as constexpr * Change local variable to use one global constexpr * restyle * Typo * Remove strings from tizen and linux platform * refactor * Fix review issue
The Call() function currently still has some callback handling code the completeEvent and callbackRes variables. These are only used when callbacks are in play, like pychip_DeviceController_Commission or pychip_DeviceController_OpenCommissioningWindow. When calling these functions CallAsyncWithCompleteCallback() needs to be used (and is beeing used in all cases). In practice, on single threaded applications this is not a problem. However, when calling the SDK from multiple threads, then another Call() Might accidentally release a call to CallAsyncWithCompleteCallback() early.
…erClient in ICDManagemenet is triggered (#33671) * Remove icd entry in icd client storage after unregisterClient is triggered * Restyled by clang-format * address comments * Update ModelCommand.cpp * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
…33677) People are making assumptions based on those, and those assumptions will come back to bite them. Just switch to using UUIDs for the release names.
* [Fabric-Bridge] Refactor device management from main * Address review comments
Removes scripts associated with the test deletion in CHIP-Specifications/chip-test-plans#4104 and CHIP-Specifications/chip-test-plans#4184
So far the automation log level was missing. Add it to the log level defines in the logging module. While at it, also rename to LOG_CATEGORY (instead of ERROR_CATEGORY) and remove duplicated log level definitions in ChipStack.
* TC-RVCRUNM-2.2: make error more verbose * Restyled by autopep8 * more verboser --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Python testing: id range check functions * add test to workflow * use range more directly * change to enums * isort * fix workflow
… to avoid random crashes due to PostEventQueue failure. (#33684) * Unregistering wifi and IP event handlers before factory reset to avoid random crashes due to post event queue failure * Restyled by clang-format * Fix the CI failure in lit-icd app --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )