[pull] master from project-chip:master #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop chip-device-ctrl and ZCL* APIs Drop the deprecated chip-device-ctrl and remove the ZCL* API from the Python CHIP controller. * Update docs to reflect chip-repl commands Update the Python CHIP controller docs to reflect the CHIP REPL instead of the now removed chip-device-ctrl tool. * Remove unused imports * Replace chip-device-ctrl with chip-repl * Update/reword main QUICK_START and READMEs * Fix wrong/buggy cross-reference * Remove common chip-device-ctrl example Remove the outdated chip-device-ctrl example and refer to the Python controller REPL documentation. * Add --ble-adapter support to CHIP REPL and update docs Add support to select the Bluetooth adapter using the common --ble-adapter command line argument. Update the advanced docs for the Python Controller. * Address review feedback * Trim list of commands/add link to official API docs
… Thread. (#33585) * Fix dnssd callback thread * Restyled by google-java-format * comment * Restyled by google-java-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
We are going to change how the estimated latency is computed anyway, at which point this test will no longer be valid.
…33520) * Some refactoring to dac revocation set generation script * restyle and linter fixes * one last lint fix * address comments * Restyled by autopep8 * add logger * Catch the exception when loading the CRL * CRL entry extension do not have a AKID extension --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Use a valid command id in TC_IDM_1_4.py The test TC_IDM_1_4.py used 0xffff_ffff as test command id. In fact this is not valid MEI according to specification. While chip seems to validate this fact later the test works. In matter.js such datatype validations are handled earlier and thats why we throw an contraint error because the value is wrong data type wise. I did not found any place in the specification where it is defined when such "semantic" data value checks should be done (unless some very specific error cases in some adapters). I think this is a theoretical topic in this case because it will hopefully never happen in real live devices 8and when it does the exact error should be irrelevant) for this test it matters because the test fails. With the change of the command ID to be a still unknown, but valid, value the issue is gone. I also think that tests should still use basically "correct" values. ;-) Thank you for considering this change. * address review feedback
* Remove oven provisionality * Commit after regen
We had a few issues: 1) Our "round-trip timeout" only accounted for one side of the round-trip needing to do MRP retransmits. So if the sender retried a few times, the last retry finally got through, then the response had to be retried a well, the sender would time out the exchange before the response was received. The fix here is to add the MRP backoff times for both the initial message and the response. 2) ReadClient could end up timing out a subscription before the server had actually given up on receiving a StatusReport in response to its ReportData, in situations where the server ended up doing MRP retries and the last MRP retry took a few seconds to get through the network. The fix here is to just estimate how long the server will be waiting for the StatusReport and not time out the subscription until then; at that point even if the server did in fact send its report on time, it will have dropped the subscription on its end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )