[pull] master from project-chip:master #573

pull · 2024-05-13T13:03:14Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

…l on the correct queue (#33410)

…n NetworkCommissioning Cluster code. (#33268) * Adding config checks for fucntions specific to only wifi and thread in NetworkCommissioning * Restlyed

) * [k32w] Add mShouldNotApply flag in OTATlvProcessor interface OTATlvProcessor::ApplyAction now has a default implementation, but derived classes are still able to overwrite this. The flag is used by the default ApplyAction implementation. If something goes wrong during ExitAction of the TLV processor, then mShouldNotApply should be set to true and the image processor should abort. In this case, the BDX transfer was already finished and calling CancelImageUpdate will not abort the transfer, hence the device will reboot even though it should not have. If ApplyAction fails during HandleApply, then the process will be aborted. Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [k32w0] Use mShouldNotApply flag in ExitAction During ExitAction, set mShouldNotApply to true if an error occurs. This ensures that the OTA will be aborted and the device does not reboot. Also remove the ApplyAction override, since the default implementation is enough. Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [k32w1] Use mShouldNotApply during ExitAction Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [k32w] Update OTA error naming All OTA errors should be prefixed with CHIP_ERROR. Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [k32w] Replace boolean mShouldNotApply with an enum class Signed-off-by: marius-alex-tache <marius.tache@nxp.com> --------- Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

This is a basic version of compile support and only x86 simulator lightning-app is supported now The compilation method is shown below: ./scripts/build/build_examples.py --target nuttx-x64-light build and compiled binaries are in the out/nuttx-x64-light directory. Detailed introduction about NuttX system can refer to this link: https://github.com/apache/nuttx Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>

guardrails · 2024-05-13T13:10:18Z

⚠️ We detected 13 security issues in this pull request:

Hard-Coded Secrets (1)

Severity

Details

Docs

Medium

Title: Base64 High Entropy String

connectedhomeip/scripts/build/builders/nuttx.py

Line 82 in 37b2fe6

'-DCMAKE_CXX_COMPILER=/opt/nuttx/gcc-13/bin/g++',

📚

More info on how to fix Hard-Coded Secrets in General.

Insecure Processing of Data (12)

Severity

Details

Docs

Medium

Title: Pointer subtraction

connectedhomeip/src/platform/NuttX/DnssdImpl.cpp

Line 677 in 37b2fe6

    
           size_t lengthWithoutProtocol = (dotPos != nullptr) ? static_cast<size_t>(dotPos - typeAndProtocol) : N;

📚

High

Title: Return address of stack variable

connectedhomeip/src/platform/NuttX/PosixConfig.cpp

Line 87 in 37b2fe6

return &gChipLinuxFactoryStorage;

📚

High

Title: Return address of stack variable

connectedhomeip/src/platform/NuttX/PosixConfig.cpp

Line 90 in 37b2fe6

return &gChipLinuxConfigStorage;

📚

High

Title: Return address of stack variable

connectedhomeip/src/platform/NuttX/PosixConfig.cpp

Line 93 in 37b2fe6

return &gChipLinuxCountersStorage;

📚

Medium

Title: Inherently dangerous strcpy family function

connectedhomeip/src/platform/NuttX/BLEManagerImpl.cpp

Line 167 in 37b2fe6

strcpy(buf, mDeviceName);

📚

Medium

Title: Inherently dangerous strcpy family function

connectedhomeip/src/platform/NuttX/BLEManagerImpl.cpp

Line 181 in 37b2fe6

strcpy(mDeviceName, deviceName);

📚

Medium

Title: Inherently dangerous strcpy family function

connectedhomeip/src/platform/NuttX/ConnectivityUtils.cpp

Line 294 in 37b2fe6

strcpy(req.ifr_name, ifname);

📚

High

Title: Variable format string for printf functions

connectedhomeip/src/platform/NuttX/CHIPLinuxStorage.cpp

Line 201 in 37b2fe6

snprintf(buf, sizeof(buf), "%" PRIu32, val);

📚

High

Title: Variable format string for printf functions

connectedhomeip/src/platform/NuttX/CHIPLinuxStorage.cpp

Line 210 in 37b2fe6

snprintf(buf, sizeof(buf), "%" PRIu64, val);

📚

High

Title: Variable format string for printf functions

connectedhomeip/src/platform/NuttX/Logging.cpp

Line 53 in 37b2fe6

vprintf(msg, v);

📚

High

Title: Variable format string for printf functions

connectedhomeip/src/platform/NuttX/Logging.cpp

Line 65 in 37b2fe6

vsnprintf(formattedMsg + len, sizeof(formattedMsg) - len, msg, v);

📚

Medium

Title: Inherently dangerous sprintf family function

connectedhomeip/src/platform/NuttX/ConnectivityManagerImpl.cpp

Line 1305 in 37b2fe6

sprintf(cmdBuffer, CHIP_DEVICE_CONFIG_LINUX_DHCPC_CMD, sWiFiIfName);

📚

More info on how to fix Insecure Processing of Data in C/C++.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Resolver list is a fixed size always, so a message of "inactive" tagged as an error seems to just fill up logs (especially seen in python repl) Co-authored-by: Andrei Litvin <andreilitvin@google.com>

* Use asyncio sleep to unblock asyncio event loop * Avoid fixed sleep in TestCaseEviction Use asyncio Event and wait_for to wait for the change and continue immediately when received. * Make TestSubscription an async test The current test implementation starves the asyncio event loop by synchronously waiting for the threading.Condition. This prevents making the SubscriptionTransaction fully leveraging the async paradigm. It probably would be possible to mix asyncio.sleep() and threading, but instead embrace the async pradigm for this test. * Make TestSubscriptionResumption an async test The current test implementation starves the asyncio event loop by synchronously waiting for the threading.Condition. This prevents making the SubscriptionTransaction fully leveraging the async paradigm. It probably would be possible to mix asyncio.sleep() and threading, but instead embrace the async pradigm for this test. * Make TestSubscriptionResumptionCapacityStep1 an async test Eliminate use of ZCLSubscribeAttribute and embrace asyncio. * Make TestSubscriptionResumptionCapacityStep2 an async test Eliminate use of ZCLSubscribeAttribute and embrace asyncio. * Remove ZCLSubscribeAttribute from subscription_resumption_timeout_test Use ReadAttribute with asyncio in subscription_resumption_timeout_test as well. * Rewrite TestWriteBasicAttributes to drop ZCLRead/WriteAttribute * Improve wait for end of update task in TestSubscription

#33371) * Converted src/controller/tests/data_model from NL to PW. * Updated to accomodate the fact that AppContext and LoopbackMessagingContext now have SetUp/SetUpTestSuite returning void. * Comment cleanup. * Reordered tests to fix dependency. * Formatting * Formatting * Added comment warning of order dependence. * Formatting * Removed unneeded conditions from SetUpTestSuite/TearDownTestSuite.

* Converted controller/tests from NL to PW unit tests. * Formatting * Omitted ControllerTests from test_components.txt

jtung-apple and others added 5 commits May 13, 2024 03:58

[Darwin] Fix MTRDeviceConnectivityMonitor DNSServiceRefDeallocate cal…

70d9a61

…l on the correct queue (#33410)

Adding config checks for functions specific to only wifi and thread i…

3600a50

…n NetworkCommissioning Cluster code. (#33268) * Adding config checks for fucntions specific to only wifi and thread in NetworkCommissioning * Restlyed

Fix crash in android tv-app when handling level commands (#33409)

ce7d400

github-actions bot added workflows examples github config lib platform darwin scripts app gn inet core labels May 13, 2024

pull bot added ⤵️ pull and removed workflows examples github config lib platform darwin scripts app gn inet core labels May 13, 2024

Remove extra logging in minmdns resolver. (#33407)

11cb2b3

Resolver list is a fixed size always, so a message of "inactive" tagged as an error seems to just fill up logs (especially seen in python repl) Co-authored-by: Andrei Litvin <andreilitvin@google.com>

github-actions bot added workflows examples github config lib platform darwin scripts app gn inet core labels May 13, 2024

github-actions bot added the controller label May 13, 2024

github-actions bot added the test driver label May 13, 2024

feasel0 and others added 2 commits May 13, 2024 15:09

Converted src/controller/tests from NL to PW unit tests. (#33351)

0180ee6

* Converted controller/tests from NL to PW unit tests. * Formatting * Omitted ControllerTests from test_components.txt

Darwin: Add missing import (#33429)

fb0394d

woody-apple merged commit fb0394d into woody-apple:master May 13, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] master from project-chip:master #573

[pull] master from project-chip:master #573

pull bot commented May 13, 2024 •

edited

Loading

guardrails bot commented May 13, 2024

[pull] master from project-chip:master #573

[pull] master from project-chip:master #573

Conversation

pull bot commented May 13, 2024 • edited Loading

guardrails bot commented May 13, 2024

pull bot commented May 13, 2024 •

edited

Loading