Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Deprecated CI_PIPELINE_FINISHED CI_PIPELINE_FILES #66

Closed
3 tasks done
sinlov opened this issue Jan 31, 2025 · 0 comments · Fixed by #67
Closed
3 tasks done

[feature]: Deprecated CI_PIPELINE_FINISHED CI_PIPELINE_FILES #66

sinlov opened this issue Jan 31, 2025 · 0 comments · Fixed by #67
Labels
enhancement New feature or request
Milestone
1.x

Comments

@sinlov
Copy link
Contributor

sinlov commented Jan 31, 2025 •
edited
Loading

Clear and concise description of the problem

woodpecker 3.x.x should remove

  • CI_PIPELINE_FINISHED
  • CI_PIPELINE_FILES

and Do not set empty environment variables

Suggested solution

add Deprecated and remind plugin migration implementations that use these variables

Alternative

No response

Additional context

No response

Validations
@sinlov sinlov added the enhancement New feature or request label Jan 31, 2025
@sinlov sinlov added this to the 1.x milestone Jan 31, 2025
@sinlov sinlov changed the title [feature]: Deprecated CI_PIPELINE_FINISHED CI_PIPELINE_STATUS CI_PIPELINE_FILES [feature]: Deprecated CI_PIPELINE_FINISHED CI_PIPELINE_FILES Jan 31, 2025
sinlov added a commit that referenced this issue Jan 31, 2025
@sinlov
feat(env): add deprecation notice for CI pipeline variables
24ae857 
feat #66

- Add note in README.md about the deprecation of CI_PIPELINE_FINISHED and CI_PIPELINE_STARTED variables
- Specify that this change affects Woodpecker server version 3.+ and later
@sinlov sinlov mentioned this issue Jan 31, 2025
Merged
@sinlov sinlov linked a pull request Jan 31, 2025 that will close this issue
66 feature deprecated ci pipeline finished ci pipeline status ci pipeline files #67
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.x
1 participant
@sinlov