Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check organization first #4723

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

qwerty287
Copy link
Contributor

closes #4691

The orgs endpoint returns an error if you call it with a user, but the users endpoint works for both orgs and users (so orgs are a subset of users).

@qwerty287 qwerty287 added bug Something isn't working forge/github github forge related labels Jan 13, 2025
@qwerty287 qwerty287 requested a review from a team January 13, 2025 12:15
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.21%. Comparing base (e51df2d) to head (7508993).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/github/github.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4723      +/-   ##
==========================================
- Coverage   28.23%   28.21%   -0.02%     
==========================================
  Files         398      398              
  Lines       28264    28265       +1     
==========================================
- Hits         7980     7975       -5     
- Misses      19574    19580       +6     
  Partials      710      710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 8779086 into woodpecker-ci:main Jan 13, 2025
7 of 9 checks passed
@qwerty287 qwerty287 deleted the fix-gh-order branch January 13, 2025 13:54
@woodpecker-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge/github github forge related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants