Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline web helpers #4639

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Inline web helpers #4639

merged 3 commits into from
Jan 2, 2025

Conversation

qwerty287
Copy link
Contributor

Functions used once just wrapping another func are just useless…

@qwerty287 qwerty287 added ui frontend related refactor delete or replace old code labels Dec 29, 2024
@qwerty287 qwerty287 requested a review from a team December 29, 2024 07:27
@xoxys
Copy link
Member

xoxys commented Jan 2, 2025

While I think using external lib methods directly instead of wrapping them makes sense why do you also moved our own helper functions from a central place? Whats the benefit? Now they cant be easily reused and the lines of code are still the same or do I miss something?

@qwerty287
Copy link
Contributor Author

Because they're only used in a single place and because we have kind of two "helper" categories: the helpers and the compositions. The helpers don't really contain much. Maybe vue has a different concept of the compositions, but that's not how we're currently using that. Instead it's just a different category of helpers. So I mainly tried to merge them. Besides that, most functions were either really simple ones or pretty specific I think.

@qwerty287 qwerty287 merged commit 28bbc4b into woodpecker-ci:main Jan 2, 2025
7 checks passed
@qwerty287 qwerty287 deleted the funcs-ui branch January 2, 2025 13:26
@woodpecker-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants