Add Bitbucket fixes to Release/2.8

[j04n-f]

Description

We currently use a fork of the original code because the following fixes prevent us from using the upstream release. Add the Bitbucket fixes to release 2.8.1.

Aesthetic Changes

• 50cff74: The UI pipeline name was using the Pull Request description. The commit changes the UI pipeline name to use the Pull Request name.
• 283f629: The UI link to the Pull Request reference was broken. Change the Pull Request reference to redirect the user to the correct Bitbucket link.

Functional Changes

• 06ae7d5: WP uses the same key for the commit status. No matter which is the triggering event. When triggering a workflow simultaneously using the pull_request and branch events, the commit status is overwritten by the last workflow to finish. This behavior allowed PRs to be merged even when the pull_request pipeline failed. Fix the issue using a different key depending on the triggering event. This change can affect those users who were using the key as an ID to block their PRs

You are doing an amazing work! Let us know if we can help you.

[pat-s]

Thanks. Can you please summarize the changes in OP and add the BB version which introduced these changes?
I guess that changing this will break WP for some users on older BB versions?

[j04n-f]

As far as I know, WP does not have BB users because the WP - BB integration was broken until we introduced the following changes:

• woodpecker-ci/plugin-git@4dfe5e1
• 3a4ffe9
• 047eb19

These changes fixed the PR workflow, which was broken. The last changes to the BB code were done almost one and a half years ago. BB did not change anything, this issue regarding the SHA length has been a recurring issue since 2021: https://jira.atlassian.com/browse/BCLOUD-21201

But, as I said, this is a hypothesis. No one complained about BB not working with WP, no one is using the BB integration.

Updated the PR description. What do you mean by "summarize the changes in OP"?

[pat-s]

Thanks for the heads-up. Might very well be that there are no BB users.
Just saw some API changes that could have originated from a major BB release (I guess they must have been at some point) and if it was somewhat recent, they might break stuff.
But you're right, there are probably no users then if it didn't work at all for you until now.

What do you mean by "summarize the changes in OP"?

Updating the PR description in the [O]riginal [P]ost. Like you now did 👍️

We usually apply such patches first to the main branch and then do a backport. While the order doesn't really matter, do you also want to add a PR for main after this got accepted? 3.x is round the corner.

[zc-devs]

We usually apply such patches first to the main branch

and then do a backport

This is a backport.

[pat-s]

Ah, got it. Thanks for clarifying.

[pat-s]

LGTM

[pat-s]

I would also be fine issuing a patch release right away given that this fix is critical to use WP in the first place for BB users. @woodpecker-ci/maintainers opinions?

[qwerty287]

Maybe fix the security issues trivy found as well...

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-4547.surge.sh