-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pagination helper to list pipelines in cli #4478
Conversation
Deployment of preview was torn down |
This doesn't work with e.g. branch and event filter. The limit is not applied to these. If you want 10 pipelines for |
Yes I know but this was already the case before thos change. Yes there is now server side filtering but not for all three options and I would now look into the open autogen client PR instead of copying everything manually to woodpecker-go again. So can we merge this PR as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, previously it was always loading the first page without any limit (afaik the default is 25). If you had a lower limit, it was working, now it will be always less if something is filtered out. But if we fix it soon it's fine for me.
You are right. Then lets keep it open for now and I will look into to clientgen first. |
the woodpecker-go currently does not have support for the new filters yes ... I'm also looking forward to generate it |
Depends-on: #4494 |
a6c8769
to
c3fbe67
Compare
c3fbe67
to
3aa6934
Compare
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <6543@obermui.de>
This PR fixes the
woodecker-cli pipeline ls
command. Before this change it was no possible to list more than 50 pipelines as this is the hardcoded limit of the API for pipelines per page.