Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont run pipeline on push events to renovate branches #4406

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 18, 2024

As we require renovate to create pull requests, the ci coverage will happen at the pull-request event

@6543 6543 added the build CI pipeline related label Nov 18, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 18, 2024

Deployment of preview was torn down

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.51%. Comparing base (e95db23) to head (8e3b108).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4406   +/-   ##
=======================================
  Coverage   27.51%   27.51%           
=======================================
  Files         382      382           
  Lines       27895    27895           
=======================================
  Hits         7676     7676           
  Misses      19532    19532           
  Partials      687      687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial idea of this was to let renovate automerge if CI checks succeeds for branch runs (which are happening in the background). This is now possible with #3348. This would reduce the renovate noise by a lot.

If checks fail, renovate will automatically create a PR anyway.

The downside is that no labels would be applied to these merge commits, which means it wouldn't play well with the release plugin.
This was one reasoning why I proposed to not only rely on labels but also on conv commits a few weeks ago.

But as this was not agreed on, branch automerge will likely never happen. In this case, removing the branch triggers makes sense.

@6543 6543 marked this pull request as ready for review November 19, 2024 17:39
@6543
Copy link
Member Author

6543 commented Nov 19, 2024

thanks for writing why it was added in the first place ...

It's better to remove stuff if you know why it existed in the first place :)

I'm personally for let the renovate auto merge, but I do wana se that through pulls ...

@pat-s pat-s enabled auto-merge (squash) November 19, 2024 17:46
@6543 6543 disabled auto-merge November 19, 2024 18:00
@6543 6543 merged commit 9b3cb06 into woodpecker-ci:main Nov 19, 2024
5 of 7 checks passed
@6543
Copy link
Member Author

6543 commented Nov 19, 2024

docs fail unrelated ... need to dig into that ...

@6543 6543 deleted the non-renovate-push-run branch November 19, 2024 18:01
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 19, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants