-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont run pipeline on push events to renovate branches #4406
Conversation
Deployment of preview was torn down |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4406 +/- ##
=======================================
Coverage 27.51% 27.51%
=======================================
Files 382 382
Lines 27895 27895
=======================================
Hits 7676 7676
Misses 19532 19532
Partials 687 687 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial idea of this was to let renovate automerge if CI checks succeeds for branch runs (which are happening in the background). This is now possible with #3348. This would reduce the renovate noise by a lot.
If checks fail, renovate will automatically create a PR anyway.
The downside is that no labels would be applied to these merge commits, which means it wouldn't play well with the release plugin.
This was one reasoning why I proposed to not only rely on labels but also on conv commits a few weeks ago.
But as this was not agreed on, branch automerge will likely never happen. In this case, removing the branch triggers makes sense.
thanks for writing why it was added in the first place ... It's better to remove stuff if you know why it existed in the first place :) I'm personally for let the renovate auto merge, but I do wana se that through pulls ... |
|
As we require renovate to create pull requests, the ci coverage will happen at the pull-request event