Require upgrade from 2.x

[qwerty287]

Remove old DB migrations and require users to upgrade to 2.x first.

I don't think this has a big impact as there won't be many still using 1.x, but not sure - what do you think about this?

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-4112.surge.sh

[6543]

What are the benefits of removing it?

Else i just would let the upgrade path as wide as maintainable ...

[qwerty287]

What are the benefits of removing it?

Less code, and especially because the migrations folder contains a lot of helper structs, but they're not always used properly. Migrations are really a somewhat critical part and requiring users to split it up can help to avoid problems if you try to upgrade from very old versions. We know that it works to upgrade from 1.x to 2.x and from 2.x to 3.x but we don't test upgrading 1.x to 3.x.
Also, I don't think there are many users that will be impacted by this, using 1.0 is a pretty bad idea and you can still update by upgrading to 2.x first.

[zc-devs]

Sounds like Nextcloud Approaching Upgrades.

[qwerty287]

In general yes, but I wouldn't be that strict. Upgrading from any version to the next major should be possible (so e.g. 2.0 to 3.0)

[codecov]

Codecov Report

Attention: Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.28%. Comparing base (4289853) to head (7dc3240).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
server/store/datastore/migration/001_add_org_id.go	50.00%	0 Missing and 1 partial ⚠️
...re/migration/004_remove_secrets_plugin_only_col.go	50.00%	0 Missing and 1 partial ⚠️
...ation/005_convert_to_new_pipeline_errors_format.go	83.33%	0 Missing and 1 partial ⚠️
...datastore/migration/007_clean_registry_pipeline.go	66.66%	0 Missing and 1 partial ⚠️
...re/datastore/migration/008_set_default_forge_id.go	83.33%	0 Missing and 1 partial ⚠️
...re/datastore/migration/009_unify_columns_tables.go	92.85%	0 Missing and 1 partial ⚠️
...e/datastore/migration/012_rename_start_end_time.go	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4112      +/-   ##
==========================================
- Coverage   26.97%   26.28%   -0.69%     
==========================================
  Files         395      373      -22     
  Lines       27414    26918     -496     
==========================================
- Hits         7395     7076     -319     
+ Misses      19315    19190     -125     
+ Partials      704      652      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[6543]

How did you generate the new test database?

[qwerty287]

Just executed it after commenting out the new migrations, so only those that were removed run.