-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul README #3995
Overhaul README #3995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the red/orange box around the screenshot?
This is the outline of my browser. But I can redo the screenshot with another browser. |
Would you consider including some examples of the environment variables that are available in CI? E.g. something like this. When I'm writing build scripts, I often find myself wondering about the format of a value for a particular environment variable, and have to run a test job to find out. |
In the readme? I wouldn't do this. In the docs it would be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine from my side, maybe we can wait for more maintainer feedback
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3995.surge.sh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3995 +/- ##
=======================================
Coverage 26.89% 26.89%
=======================================
Files 394 394
Lines 27467 27467
=======================================
Hits 7388 7388
Misses 19380 19380
Partials 699 699 ☔ View full report in Codecov by Sentry. |
Long overdue.
I applied some subjective changes, feedback welcome.