Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set pod annotations and labels from step #3609

Merged
merged 9 commits into from
May 11, 2024
Merged

Ability to set pod annotations and labels from step #3609

merged 9 commits into from
May 11, 2024

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Apr 12, 2024

Closes #3188

@qwerty287 qwerty287 added enhancement improve existing features backend/kubernetes labels Apr 14, 2024
@zc-devs
Copy link
Contributor Author

zc-devs commented Apr 28, 2024

@qwerty287, maybe build images here too and @dominic-p could test?

@qwerty287 qwerty287 added the build_pr_images If set, the CI will build images for this PR and push to Dockerhub label Apr 28, 2024
@dominic-p
Copy link
Contributor

Thanks for the work on this @zc-devs! I'm ready to test as soon as the pipelines run. It looks like they are pending approval at the moment.

@zc-devs
Copy link
Contributor Author

zc-devs commented May 1, 2024

This one is ready

@qwerty287 qwerty287 added this to the 2.6.0 milestone May 1, 2024
@dominic-p
Copy link
Contributor

Ok, I was able to test this tonight, and it's working as expected for me! If you would like, I can take a stab at a PR for the docs. Just let me know.

@zc-devs
Copy link
Contributor Author

zc-devs commented May 3, 2024

I can take a stab at a PR for the docs

It would be great! Thanks in advance.

dominic-p added a commit to dominic-p/woodpecker that referenced this pull request May 6, 2024
@dominic-p
Add documentation for setting kubernetes labels and annotations
36606d3 
See woodpecker-ci#3609
@dominic-p dominic-p mentioned this pull request May 6, 2024
Merged
@zc-devs
Copy link
Contributor Author

zc-devs commented May 8, 2024

@qwerty287, seems, we are ready for merge here and there.

qwerty287
qwerty287 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far to me - please note that we currently have issues with downloading Go dependencies in the CI so I probably won't be able to merge this

@qwerty287 qwerty287 merged commit ae72102 into woodpecker-ci:main May 11, 2024
6 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request May 11, 2024
Merged
1 task
@qwerty287 qwerty287 modified the milestones: 2.6.0, 2.5.0 May 11, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 1, 2024
Merged
@zc-devs zc-devs deleted the 3188-step-pod-annotations-labels branch June 4, 2024 14:40
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@zc-devs @qwerty287 @6543
Ability to set pod annotations and labels from step (woodpecker-ci#3609)
413a66f 
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-s pat-s pat-s left review comments

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
backend/kubernetes build_pr_images If set, the CI will build images for this PR and push to Dockerhub enhancement improve existing features
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Add the ability to set arbitrary annotations on Kubernetes pods
4 participants
@zc-devs @dominic-p @pat-s @qwerty287