Missed deprecation #2047
Merged
Missed deprecation #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we don't need to frontport this as #2048 will apply same docs changes and the fix. and drop the deprecated var. |
This comment was marked as off-topic.
This comment was marked as off-topic.
xoxys
reviewed
Jul 28, 2023
There was a problem hiding this comment.
This test data is till using CI_SYSTEM_ARCH instead of CI_SYSTEM_PLATFORM:
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/frontend/metadata/drone_compatibility_test.go#L76
This test file is still using both CI_SYSTEM_ARCH and CI_SYSTEM_PLATFORM:
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/frontend/metadata_test.go#L85-L86
Don't know if that matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the refactoring we did move from CI_SYSTEM_ARCH to CI_SYSTEM_PLATFORM
but we missed to set the var in the agent pipeline tracer, so the Kubernetes backend did not work with it.
this fix it and also make it deprecated as intended