Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent auth #1952

Merged
merged 6 commits into from
Jul 8, 2023
Merged

Fix agent auth #1952

merged 6 commits into from
Jul 8, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 8, 2023

if no global agent secret set, disable agent registration via it

@6543 6543 added the security label Jul 8, 2023
@6543 6543 added this to the 1.0.0 milestone Jul 8, 2023
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Jul 8, 2023
@6543 6543 mentioned this pull request Jul 8, 2023
@6543 6543 added the backport-done indicates that this pull has been backported label Jul 8, 2023
@6543 6543 enabled auto-merge (squash) July 8, 2023 15:58
@6543 6543 merged commit 6c58e9d into woodpecker-ci:master Jul 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (cef135e) 39.31% compared to head (a6277bf) 39.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1952      +/-   ##
==========================================
- Coverage   39.31%   39.28%   -0.04%     
==========================================
  Files         177      177              
  Lines       10725    10734       +9     
==========================================
  Hits         4217     4217              
- Misses       6214     6223       +9     
  Partials      294      294              
Impacted Files Coverage Δ
server/grpc/auth_server.go 0.00% <0.00%> (ø)
server/model/settings.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lafriks pushed a commit that referenced this pull request Jul 8, 2023
backport #1952

don't authenticate agent if no global agent token is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done indicates that this pull has been backported security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants