Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow steps/services to have same name #3109

Closed
qwerty287 opened this issue Jan 3, 2024 · 3 comments · Fixed by #3143
Closed

Allow steps/services to have same name #3109

qwerty287 opened this issue Jan 3, 2024 · 3 comments · Fixed by #3143
Labels
bug Something isn't working
Milestone
2.2.0

Comments

@qwerty287
Copy link
Contributor

See #3079

Services can't have names that steps have, also adding another step clone does not work.

I think we can also disallow this but then we should add a linter for it.
@qwerty287 qwerty287 added the enhancement improve existing features label Jan 3, 2024
@qwerty287 qwerty287 mentioned this issue Jan 3, 2024
Merged
@6543
Copy link
Member

6543 commented Jan 4, 2024

No woodpecker should just handle it!

We use uuid's for all steps internaly so equal names should not have any impact

@6543
Copy link
Member

6543 commented Jan 4, 2024

(So i considder it a bug)

@6543 6543 added the bug Something isn't working label Jan 4, 2024
@qwerty287 qwerty287 removed the enhancement improve existing features label Jan 4, 2024
@qwerty287 qwerty287 added this to the 2.2.0 milestone Jan 4, 2024
This was referenced Jan 8, 2024
Merged
Merged
@6543
Copy link
Member

6543 commented Jan 9, 2024

found it finally: #3143

tested with docker backend and config:

steps:
    wait:
        image: "bash"
        commands:
            - "echo type: step"
            - "sleep 10s"
            - "echo hihi step"
            - "sleep 30s"

services:
    wait:
        image: "bash"
        commands:
            - "echo type: service"
            - "sleep 10s"
            - "echo hihi service"
            - "sleep 30s"

6543 added a commit that referenced this issue Jan 9, 2024
@6543
Use UUID instead of step name where possible (#3136)
c64340c 
things I found while looking at  #3109
@6543 6543 closed this as completed in #3143 Jan 9, 2024
6543 added a commit that referenced this issue Jan 9, 2024
@6543 @anbraten
Use step uuid instead of name in GRPC status calls (#3143)
aab2f0e 
close #3109

~~also fix start time of steps to be set correctly~~ edgecase do not hit
anymore as we have a clear sepperation between workflows and steps now
:)

---------

Co-authored-by: Anbraten <anton@ju60.de>
fernandrone pushed a commit to quintoandar/woodpecker that referenced this issue Feb 1, 2024
@6543 @fernandrone
Use UUID instead of step name where possible (woodpecker-ci#3136)
abfa12d 
things I found while looking at  woodpecker-ci#3109
fernandrone pushed a commit to quintoandar/woodpecker that referenced this issue Feb 1, 2024
@6543 @anbraten @fernandrone
Use step uuid instead of name in GRPC status calls (woodpecker-ci#3143)
ec3ed8f 
close woodpecker-ci#3109

~~also fix start time of steps to be set correctly~~ edgecase do not hit
anymore as we have a clear sepperation between workflows and steps now
:)

---------

Co-authored-by: Anbraten <anton@ju60.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Use step uuid instead of name in GRPC status calls 6543-forks/woodpecker
2 participants
@6543 @qwerty287