Skip to content

Commit

Permalink
Update test.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
@qwerty287
qwerty287 authored Dec 8, 2024
1 parent ba7f6d7 commit 6843650
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .woodpecker/test.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ steps:
environment:
WOODPECKER_DISABLE_UPDATE_CHECK: true
WOODPECKER_LINT_STRICT: true
WOODPECKER_PLUGINS_PRIVILEGED: 'docker.io/woodpeckerci/plugin-docker-buildx:5.0.0'
WOODPECKER_PLUGINS_PRIVILEGED: 'docker.io/woodpeckerci/plugin-docker-buildx:5.0.0,docker.io/woodpeckerci/plugin-docker-buildx:5.1.0'
when:
- event: pull_request
path:
Expand Down

3 comments on commit 6843650

@pat-s
Copy link
Contributor

@pat-s pat-s commented on 6843650 Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still heavy in favor of removing this (or setting no tag at all) until semver range checks are implemented. To me, this feature is maintenance-hell and incomplete.

@anbraten
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "blacklist" that was suggested some time ago might be a solution as well. So we would be able to use WOODPECKER_PLUGINS_PRIVILEGED: 'docker.io/woodpeckerci/plugin-docker-buildx (without a tag) and those bad versions would be detected by linter using this blacklist which could be similar to https://woodpecker-ci.org/version.json.

@pat-s
Copy link
Contributor

@pat-s pat-s commented on 6843650 Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be an alternative solution that sounds legit.
As there aren't any other public users of this instance, I still suggest to drop the tag part in here.

Please sign in to comment.