Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes the check when running
npm run test:e2e
; it now correctly exits with an error if the containers are not running:It also sets the project-name for
npm run test:e2e-up
to avoid orphaned containers when runningnpm run test:e2e-down
Testing instructions
npm run test:e2e-setup
npm run test:e2e-up
, and check that the project name used isenv
npm run test:e2e-down
and verify it has no effect.npm run test:e2e-setup
and check that the descriptive error message is displayed:env
containers created during step 4.npm run test:e2e-up
, and check that the correct project name is used:npm run test:e2e-down
, and verify that the containers are correctly removed.Changelog entry
Changelog Entry Comment
Comment
Post merge