Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E run/up check #3990

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Fix E2E run/up check #3990

merged 4 commits into from
Feb 27, 2025

Conversation

diegocurbelo
Copy link
Member

@diegocurbelo diegocurbelo commented Feb 26, 2025

Changes proposed in this Pull Request:

This PR fixes the check when running npm run test:e2e; it now correctly exits with an error if the containers are not running:

Screenshot 2025-02-26 at 19 35 12

It also sets the project-name for npm run test:e2e-up to avoid orphaned containers when running npm run test:e2e-down

Testing instructions

  1. Checkout the develop develop
  2. Make sure the E2E containers are stopped
  3. Run npm run test:e2e-setup
    Screenshot 2025-02-26 at 20 00 31
  4. Run npm run test:e2e-up, and check that the project name used is env
    Screenshot 2025-02-26 at 20 01 38
  5. Run npm run test:e2e-down and verify it has no effect.
  6. Checkout this branch
  7. Re-run npm run test:e2e-setup and check that the descriptive error message is displayed:
    Screenshot 2025-02-26 at 20 03 00
  8. Manually delete the env containers created during step 4.
  9. Re-run npm run test:e2e-up, and check that the correct project name is used:
    Screenshot 2025-02-26 at 20 05 25
  10. Re-run npm run test:e2e-down, and verify that the containers are correctly removed.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@diegocurbelo diegocurbelo changed the title Tweak/fix e2e run checks Fix E2E run/up check Feb 26, 2025
@diegocurbelo diegocurbelo marked this pull request as ready for review February 26, 2025 23:08
@diegocurbelo diegocurbelo requested review from a team and Mayisha and removed request for a team February 26, 2025 23:08
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🎉

Before

Screenshot 2025-02-27 at 4 49 53 PM

After

Screenshot 2025-02-27 at 4 54 19 PM Screenshot 2025-02-27 at 4 54 52 PM

@diegocurbelo diegocurbelo merged commit df929cc into develop Feb 27, 2025
44 checks passed
@diegocurbelo diegocurbelo deleted the tweak/fix-e2e-run-checks branch February 27, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants