Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing E2E tests due to login step failure #3615

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Nov 19, 2024

Changes proposed in this Pull Request:

Fixes failing e2e tests by updating the selector for the login button.

The old selector no longer works because a screen reader element, <h1 class="screen-reader-text">Log In</h1>, is being selected instead of the button we want.

Error log:

- Trying to log-in as admin...
User log-in failed, Retrying... 1/1. page.click: Timeout 30000ms exceeded.
Call log:
  - waiting for locator('text=Log In')
  -   locator resolved to 2 elements. Proceeding with the first one: <h1 class="screen-reader-text">Log In</h1>
  - attempting click action
  -   waiting for element to be visible, enabled and stable
  -   element is visible, enabled and stable
  -   scrolling into view if needed
  -   done scrolling
  -   element is outside of the viewport

Testing instructions

E2E tests (Default) do not fail at the login step.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@annemirasol annemirasol requested review from a team and wjrosa and removed request for a team November 19, 2024 16:57
@annemirasol annemirasol self-assigned this Nov 19, 2024
Copy link
Contributor

@wjrosa wjrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really nice, Anne! Thank you for working on this 👍

@annemirasol annemirasol merged commit 3e56eca into develop Nov 19, 2024
34 of 35 checks passed
@annemirasol annemirasol deleted the fix/failing-e2e-login branch November 19, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants