Removing saved cards when setting is disabled #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegocurbelo
requested changes
Jun 9, 2024
There was a problem hiding this comment.
Thanks for fixing this, @wjrosa, tests nicely 👍🏼
I added a suggestion to update the woocommerce_saved_payment_methods_list filter callback phpdoc
includes/payment-methods/class-wc-stripe-upe-payment-gateway.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Curbelo <diego@curbelo.com>
diegocurbelo
approved these changes
Jun 10, 2024
Mayisha
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Removing saved cards when setting is disabled * Changelog and readme updates * Adding specific unit tests * Update includes/payment-methods/class-wc-stripe-upe-payment-gateway.php Co-authored-by: Diego Curbelo <diego@curbelo.com> --------- Co-authored-by: Wesley Rosa <wesley.rosa@automattic.com> Co-authored-by: Diego Curbelo <diego@curbelo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3142
Changes proposed in this Pull Request:
Currently, when disabling the "Enable payments via saved cards" settings in the new checkout experience, selecting the previously saved cards is still possible. This PR fixes that by filtering the saved cards when the setting is "on".
Testing instructions
changelog.txtandreadme.txt(or does not apply)Post merge