-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Split PE] Fix purchasing with Alipay with our deferred intent changes #2948
[Split PE] Fix purchasing with Alipay with our deferred intent changes #2948
Conversation
…non-reusable UPE methods
Noting that this PR also fixes #2942. When using Boleto or OXXO the |
Confirming that this PR fixes #2940 too. Giropay, EPS, P24 does not show the PHP fatal error on order received page anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @mattallan ! Looks good to me 🙂
✅ Placing an order with Alipay is successfully completed in both the shortcode and block checkout pages - The error isn't happening anymore.
✅ The code changes make sense to me.
Glad that this also covered the problems we were getting with other APMs.
Fixes #2939
Changes proposed in this Pull Request:
With the latest Split dPE changes, purchasing a product with Alipay resulted in the following checkout notice:

Stripe logs had the following error:
This issue was caused by the
stripe_alipay
payment method not being handled in JS by our processPayments function. Fixed by 63922cf.After fixing this, attempting to checkout with Alipay resulted in:

The issue here is caused by our
process_payment_with_deferred_intent()
returning a#wc-stripe-confirm-%s:%s:%s:%s
redirect URL. 3f4aa0e fixes the issue by handling properly fetching the redirect URL to alipay from the intent object.Important
There are a few smaller changes I added in this PR:
Undefined array key ""
andAttempt to read property "id" on null
PHP warnings coming from theget_upe_gateway_id_for_order()
functionTesting instructions
add/deferred-intent
branchchangelog.txt
andreadme.txt
(or does not apply)Post merge