Remove APM payment methods in Stripe when their tokens are deleted locally #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were only checking it belonged to the main gateway. Since Split PE, APMs have their own gateway so we needed to change this check
4 tasks
9516976
into
fix/2872-dPE-APM-subscription-support
32 checks passed
james-allan
added a commit
that referenced
this pull request
Feb 15, 2024
…rred intent (#2883) * Add support flags to Stripe UPE methods * Set the wc-stripe-is-deferred-intent flag when processing payments via tokens on the block checkout * Add bancontact and ideal to the list of gateways that require a mandate * Set the subscriptions payment method ID when setting the payment token source * Fix saved tokens for APMs like iDEAL, Bancontact and SEPA * fix typo and fetch the payment method object * Make sure to pass offsession flag to block payment elements if the cart contains a subs cription or saved tokens are enabled * Set the payment method ID on the subscription when the payment method is updated * Set the order and subscription payment method to the upe gateway's ID * Map payment method to the gateway ID should be recorded on the subscription * Set payment method title and ID to the APM used * Make sure UPE methods can call methods on the main instance of the UPE gateway * Fix undefined $name error * Reinstate the process payment function for upe methods * Only attach hooks in the subscriptions trait once * Process UPE payment method refunds via the UPE gateway * Always use the source object's payment type when processing off session payments * Use new helper function for determining the payment method id of a upe method object * Remove APM payment methods in Stripe when their tokens are deleted locally (#2902) * Check whether the deleted token belongs to a reusable gateway Before, we were only checking it belonged to the main gateway. Since Split PE, APMs have their own gateway so we needed to change this check * Move the try/catch blocks up in the method * Add Bancontact, Ideal, and Sofort to the static list of reusable gateways * Add subscription support for Sofort * Add multiple subscription support flags to Bancontact, iDEAL, Sofort methods --------- Co-authored-by: Danae Millan <41606954+a-danae@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2898
Changes proposed in this Pull Request:
Testing instructions
Test again using Bancontact and SEPA (and Sofort, once it's included in the base branch).
changelog.txtandreadme.txt(or does not apply)Post merge