Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Sofort from the settings page when it's disabled and UPE is enabled #2873

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

a-danae
Copy link
Contributor

@a-danae a-danae commented Feb 2, 2024

Changes proposed in this Pull Request:

  • When Sofort is disabled, hide it from the list of UPE payment methods.

Sofort showing up in the Payment methods list is a regression. Things work as expected in develop.
For some background, Sofort is being deprecated as a standalone payment method Ref. We're already hiding this payment gateway in the non-UPE experience.

Before After
image image

Testing instructions

  1. Check out the add/deferred-intent branch.
  2. Enable UPE, under the Stripe's settings tab (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=settings) > Advanced settings > Enable the updated checkout experience
  3. Enable Sofort, under the Stripe's payment methods tab (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=methods)
  4. Check out this branch and reload the Payment methods tab
  5. Confirm that Sofort continues to appear on the list
  6. Disable Sofort, save, and reload the page
  7. Confirm that Sofort is no longer on the list

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@a-danae a-danae changed the base branch from develop to add/deferred-intent February 2, 2024 19:58
@a-danae a-danae marked this pull request as ready for review February 10, 2024 16:18
@a-danae a-danae requested a review from Mayisha February 10, 2024 16:18
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. If Sofort is disabled, it does not show up in the payment method list for both UPE enabled/disabled states. 👍

@a-danae a-danae merged commit f7f7e12 into add/deferred-intent Feb 13, 2024
32 checks passed
@a-danae a-danae deleted the fix/hide-sofort-upe branch February 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants