Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename singleton to avoid 3rd party plugin conflict #1387

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

allendav
Copy link
Contributor

@allendav allendav commented Dec 1, 2020

Changes proposed in this Pull Request:

Issue: #1375
Fixes #1375

Description: Renames the singleton to avoid conflicts with the https://wordpress.org/plugins/woo-stripe-payment/ plugin

Testing instructions


  • Make sure your changes respect WordPress' coding standards.
  • Did you make changes, or create a new .js file? If Gruntfile.js exists in the repo, make sure to run grunt.

(remove me)

  • Did I add a title? A descriptive, yet concise, title.
  • How can this code break?
  • What are we doing to make sure this code doesn't break?

@v18 v18 requested review from v18 and removed request for v18 December 2, 2020 08:46
@reykjalin
Copy link
Contributor

I wanted to take a look at this PR and try to test it, but it seems I don't have any issues with enabling the woo-stripe-payment plugin since I can't go through the Stripe Connect authentication; I don't have confirmed bank details associated with my account, which is required to complete the authentication.

I didn't find a way to enter the publishable and secret keys manually either. If there's a way to do that I'd be happy to take a look at this again.

FWIW the changes look good, I just can't test them 🙂

cc @v18 @dechov

@allendav
Copy link
Contributor Author

allendav commented Dec 9, 2020

@reykjalin - did you try testing with a version older than 3.2.8? https://wordpress.org/plugins/woo-stripe-payment/#developers

@reykjalin
Copy link
Contributor

@allendav ah, I did not! And I just noticed following your comment that they already changed the name of their function as well.

In any case, using a version older than 3.2.8 causes a fatal error on master and no error on this branch. LGTM! :shipit:

@allendav allendav merged commit cf86c63 into master Dec 10, 2020
@frosso frosso deleted the fix/1375 branch August 12, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 4.5.4 function name conflict
2 participants