Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt, via admin notice, to set API keys if not set. #10

Merged
merged 2 commits into from
May 24, 2016
Merged

Prompt, via admin notice, to set API keys if not set. #10

merged 2 commits into from
May 24, 2016

Conversation

gedex
Copy link
Member

@gedex gedex commented May 24, 2016 •
edited
Loading

Fixes #3.

Changes proposed in this Pull Request:

  • Add admin notice globally when secret key is empty. This acts as CTA for merchant when choosing Stripe via on-boarding wizard.
  • Make sure your changes respect WordPress' coding standards.
  • Did you make changes, or create a new .js file? If Gruntfile.js exists in the repo, make sure to run grunt.

@gedex
Copy link
Member Author

gedex commented May 24, 2016

@roykho please review.

@gedex
Removed sanitize_html_class in attr.
18eb229 
This would allow us to pass multiple classes, especially for prompt
setting.
@roykho
Copy link
Member

roykho commented May 24, 2016

LGTM!

@gedex gedex merged commit 2ef3d87 into master May 24, 2016
@gedex gedex deleted the issues/3/prompt-to-setting branch May 24, 2016 18:49
@jabba2324 jabba2324 mentioned this pull request Nov 28, 2017
Closed
@dougaitken dougaitken mentioned this pull request May 18, 2020
Closed
@colmtroy colmtroy mentioned this pull request Nov 18, 2021
Closed
@isaklafleur isaklafleur mentioned this pull request Nov 21, 2022
Closed
@dineshinau dineshinau mentioned this pull request Jan 22, 2023
Closed
@imodouglas imodouglas mentioned this pull request Nov 6, 2023
Closed
@gglobalstep gglobalstep mentioned this pull request Feb 28, 2024
Closed
3 tasks
@marcus-abrahamsson marcus-abrahamsson mentioned this pull request Mar 28, 2024
Closed
@nicdwilson nicdwilson mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gedex @roykho