Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove propTypes definitions from Add to Cart #9615

Merged
merged 3 commits into from
May 29, 2023

Conversation

hritikchaudhary
Copy link
Contributor

Fixes #9547

Changes in the PR:

Removed propTypes definitions from Newest Products block, price filters, add-to-cart and product-list block.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@nielslange nielslange self-requested a review May 29, 2023 03:14
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this part, @hritikchaudhary. The changes look great, and all CI checks on #9619 passed, so I'm going to merge this PR. Keep up the great work! 🙌

@nielslange nielslange added this to the 10.4.0 milestone May 29, 2023
@nielslange nielslange merged commit f105e04 into woocommerce:trunk May 29, 2023
@tarunvijwani tarunvijwani added the type: bug The issue/PR concerns a confirmed bug. label Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace propTypes with TypeScript definitions
3 participants