This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Stack cart and checkout buttons on smaller screens #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +1 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
Hi @nefeline - just checking if you had a chance to take a look at this? :) |
nefeline
approved these changes
May 30, 2023
|
Regarding:
👍 I would just recommend adding this note to #9557 as well for future reference.
Thanks for the ping, this PR was on my to-do list for today already: the last (but not least!) review before my AFK :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9557
This PR removes a curious
display: noneon theView my cartbutton and in addition, styles the buttons to stack on smaller screens.Note that I opted not to put
CheckoutbeforeView my cartbutton as in the suggested design because there is not clean way to make thetabbingorder to work well which would introduce an accessibility issue. For example changingorderproperty on the two buttons in CSS would indeed visually work however tabbing would then be off. You would need to utilizetabindexand have that change based on browser width via JS but in this case I don't think that is urgent.Accessibility
prefers-reduced-motionScreenshots
Testing
User Facing Testing
Mini Cartblock.View my cartandCheckoutbuttons are visible and side by side.View my cartandCheckoutbuttons are visible and now stacked top and bottom.WooCommerce Visibility
Changelog